Skip to content

Conversation

@Aslemammad
Copy link
Member

For progress on #321

Comment on lines 118 to 124
let packMethod: PackMethod = 'npm'

if (args.pnpm) {
packMethod = "pnpm";
} else if (args.yarn) {
packMethod = "yarn";
}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
let packMethod: PackMethod = 'npm'
if (args.pnpm) {
packMethod = "pnpm";
} else if (args.yarn) {
packMethod = "yarn";
}
enum SUPPORT_PACKAGE_MANAGER {
PNPM = 'pnpm',
YARN = 'yarn',
NPM = 'npm'
}
const packMethod: PackMethod = SUPPORT_PACKAGE_MANAGER[args as keyof SUPPORT_PACKAGE_MANAGER] || SUPPORT_PACKAGE_MANAGER.NPM

@continuous-releases-staging
Copy link

continuous-releases-staging bot commented Feb 21, 2025

Open in Stackblitzexample-1example-2

npm i https://9f2d7926.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/pkg-pr-new@329
npm i https://9f2d7926.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-a@329
npm i https://9f2d7926.stackblitz-cr.pages.dev/stackblitz-labs/pkg.pr.new/playground-b@329

commit: 90f15ff

@Aslemammad Aslemammad merged commit 88bbad4 into main Feb 21, 2025
6 checks passed
@Aslemammad Aslemammad deleted the feat/yarn-pack branch February 21, 2025 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants