Skip to content

feat: add link to webcontainers.io #202

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Aug 6, 2024
Merged

feat: add link to webcontainers.io #202

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
7aecff3
feat: add link to webcontainers.io
AriPerkkio Aug 1, 2024
d6221e7
feat: localization for "Powered by" text
AriPerkkio Aug 1, 2024
825a143
fix: code review
AriPerkkio Aug 5, 2024
82db591
fix: code review
AriPerkkio Aug 5, 2024
c6c267f
fix: code review, primary+secondary links
AriPerkkio Aug 5, 2024
1833d02
fix: code review
AriPerkkio Aug 5, 2024
7ab9129
fix: code review
AriPerkkio Aug 5, 2024
f487ce7
fix: code review
AriPerkkio Aug 6, 2024
56b933c
Merge branch 'main' into feat/webcontainers-link
Nemikolh Aug 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions docs/tutorialkit.dev/src/content/docs/reference/configuration.mdx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,9 +56,9 @@ type I18nText = {
editPageText?: string

/**
* Text shown before webcontainer link.
* Text of the webcontainer link.
*
* @default 'Powered by'
* @default 'Powered by Webcontainer'
*/
webcontainerLinkText?: string,

Expand Down
Binary file modified docs/tutorialkit.dev/src/content/docs/reference/images/theming-webcontainers.png
View file
Open in desktop
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 5 additions & 5 deletions packages/astro/src/default/components/TutorialContent.astro
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,10 +39,10 @@ const { Markdown, editPageLink, prev, next } = lesson;
</div>
</div>

<p class="mt-6 font-size-3.5 text-tk-elements-webcontainersLink-textColor">
<a
class="inline-block mt-6 font-size-3.5 underline text-tk-elements-webcontainersLink-textColor hover:text-tk-elements-webcontainersLink-textColorHover"
href="https://webcontainers.io/"
>
{lesson.data.i18n!.webcontainerLinkText}
<a class="underline hover:text-tk-elements-webcontainersLink-textColorHover" href="https://webcontainers.io/"
>webcontainers.io</a
>
</p>
</a>
</div>
2 changes: 1 addition & 1 deletion packages/astro/src/default/utils/content/default-localization.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ export const DEFAULT_LOCALIZATION = {
noPreviewNorStepsText: 'No preview to run nor steps to show',
startWebContainerText: 'Run this tutorial',
editPageText: 'Edit this page',
webcontainerLinkText: 'Powered by',
webcontainerLinkText: 'Powered by Webcontainer',
filesTitleText: 'Files',
prepareEnvironmentTitleText: 'Preparing Environment',
toggleTerminalButtonText: 'Toggle Terminal',
Expand Down
6 changes: 3 additions & 3 deletions packages/types/src/schemas/i18n.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,11 +16,11 @@ export const i18nSchema = z.object({
editPageText: z.string().optional().describe('Text of the edit page link.'),

/**
* Text shown before webcontainer link.
* Text of the webcontainer link.
*
* @default 'Powered by'
* @default 'Powered by Webcontainer'
*/
webcontainerLinkText: z.string().optional().describe('Text shown before webcontainer link.'),
webcontainerLinkText: z.string().optional().describe('Text of the webcontainer link.'),

/**
* Text shown when there are no previews or steps to show in the prepare environment section.
Expand Down