fix(astro): sub folders not working on Windows #225
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
AriPerkkio
commented
Aug 7, 2024
AriPerkkio
commented
- Fixes Subfolders on windows do not work #209
|
|
AriPerkkio
commented
Aug 7, 2024
Comment on lines
+5
to
+17
| test('getFilesRefList returns files', async () => { | ||
| const files = await getFilesRefList('test/fixtures/files', ''); | ||
|
|
||
| expect(files).toMatchInlineSnapshot(` | ||
| [ | ||
| "test-fixtures-files.json", | ||
| [ | ||
| "/first.js", | ||
| "/nested/directory/second.ts", | ||
| ], | ||
| ] | ||
| `); | ||
| }); |
There was a problem hiding this comment.
Failure on Windows CI before fix:
❯ src/default/utils/content/files-ref.spec.ts (1 test | 1 failed) 26ms ❯ src/default/utils/content/files-ref.spec.ts > getFilesRefList returns files → Snapshot `getFilesRefList returns files 1` mismatched ⎯⎯⎯⎯⎯⎯⎯ Failed Tests 1 ⎯⎯⎯⎯⎯⎯⎯ FAIL src/default/utils/content/files-ref.spec.ts > getFilesRefList returns files Error: Snapshot `getFilesRefList returns files 1` mismatched - Expected + Received [ "test-fixtures-files.json", [ "/first.js", - "/nested/directory/second.ts", + "/nested\directory\second.ts", ], ]
https://github.com/stackblitz/tutorialkit/actions/runs/10287876681/job/28471979082?pr=225
AriPerkkio
commented
Aug 7, 2024
Comment on lines
72
to
84
| // create snapshot of lesson, solution and template file reference JSONs | ||
| const lessonJsons = distFiles.filter((file) => file.endsWith('-files.json')); | ||
| const solutionJsons = distFiles.filter((file) => file.endsWith('-solution.json')); | ||
| const templateJsons = distFiles.filter((file) => file.startsWith('template-') && file.endsWith('.json')); | ||
|
|
||
| const contents = [...lessonJsons, ...solutionJsons, ...templateJsons].reduce((jsons, current) => { | ||
| const fileJson = JSON.parse(readFileSync(path.join(dest, 'dist', current), 'utf8')); | ||
| const filenames = Object.keys(fileJson); | ||
|
|
||
| return { ...jsons, [current]: filenames }; | ||
| }, {}); | ||
|
|
||
| expect(JSON.stringify(contents, null, 2)).toMatchSnapshot('built project file references'); |
There was a problem hiding this comment.
This assertion is unrelated to the bug. I first thought the problem would be here and created this test case to see if it passes on Windows - it did.
It seems useful so let's include it as well.
AriPerkkio
force-pushed
the
fix/windows-sub-folders
branch
from
c0af565 to
e44d4c8
Compare
AriPerkkio
changed the title
AriPerkkio
commented
Aug 7, 2024
| @@ -5,6 +5,7 @@ on: | |||
| branches: | |||
| - main | |||
| pull_request: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
This is useful for contributors. It allows them (and me) to run CI manually on specific branch on forks.
There was a problem hiding this comment.
Oh that's a really nice addition! 😃
Nemikolh
approved these changes
Aug 7, 2024
| @@ -5,6 +5,7 @@ on: | |||
| branches: | |||
| - main | |||
| pull_request: | |||
| workflow_dispatch: | |||
There was a problem hiding this comment.
Oh that's a really nice addition! 😃
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.