Skip to content

Refactor tox workflow, remove Python 3.6, and switch to Ubuntu latest runners #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 2, 2025
Merged

Refactor tox workflow, remove Python 3.6, and switch to Ubuntu latest runners #53

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
eb6c539
Stop using Ubuntu Focal runners
Alex-Welsh Feb 12, 2025
9d74c4d
Remove Python 3.6 support
Alex-Welsh Apr 1, 2025
4809caa
Refactor tox workflow matrix into separate step
Alex-Welsh Apr 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/tag-and-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ name: Tag & Release
required: false
jobs:
turnstyle:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
name: Serialise runs of this workflow
permissions:
actions: read
Expand All @@ -28,7 +28,7 @@ jobs:
env:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
tag:
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
env:
naming-things-is-hard-repository: stackhpc/naming-things-is-hard
name: Automatic tagging for ${{ github.ref_name }} 🏷
Expand Down Expand Up @@ -59,7 +59,7 @@ jobs:
run: naming-things-is-hard/os-downstream-tag.py --release $(basename $(git rev-parse --abbrev-ref HEAD))
release:
needs: [tag]
runs-on: ubuntu-20.04
runs-on: ubuntu-latest
name: Release newly generated tag 🏷
steps:
- name: Github checkout 🛎 [${{ github.repository }}]
Expand Down
109 changes: 71 additions & 38 deletions .github/workflows/tox.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,62 +3,95 @@ name: Tox Workflow
'on':
workflow_call:
jobs:
tox:
runs-on: ubuntu-20.04
strategy:
fail-fast: false
matrix:
environment: [pep8,py3]
python-minor-version: [6,8,10,12]
is-not-python36:
- ${{

define-matrix:
runs-on: ubuntu-latest
outputs:
tox-matrix: ${{ steps.matrix.outputs.tox-matrix }}
steps:
- name: Define Tox matrix
id: matrix
env:
PY3_8: ${{
(github.base_ref == 'stackhpc/yoga') ||
(github.ref == 'refs/heads/stackhpc/yoga') ||
(github.base_ref == 'stackhpc/zed') ||
(github.ref == 'refs/heads/stackhpc/zed') ||
(github.base_ref == 'stackhpc/2023.1') ||
(github.ref == 'refs/heads/stackhpc/2023.1') ||
(((github.base_ref == 'stackhpc/2024.1') ||
(github.ref == 'refs/heads/stackhpc/2024.1')) &&
(github.repository != 'stackhpc/kayobe'))
}}
PY3_10: ${{
(github.base_ref == 'stackhpc/zed') ||
(github.ref == 'refs/heads/stackhpc/zed') ||
(github.base_ref == 'stackhpc/2023.1') ||
(github.ref == 'refs/heads/stackhpc/2023.1') ||
(github.base_ref == 'stackhpc/2023.2') ||
(github.ref == 'refs/heads/stackhpc/2023.2') ||
(github.base_ref == 'stackhpc/2024.1') ||
(github.ref == 'refs/heads/stackhpc/2024.1') ||
(github.base_ref == 'stackhpc/2025.1') ||
(github.ref == 'refs/heads/stackhpc/2025.1') ||
(github.base_ref == 'stackhpc/master') ||
(github.ref == 'refs/heads/stackhpc/master')
}}
is-not-python38:
- ${{
((github.repository == 'stackhpc/kayobe') &&
((github.base_ref == 'stackhpc/2024.1') ||
(github.ref == 'refs/heads/stackhpc/2024.1'))) ||
}}
PY3_12: ${{
(github.base_ref == 'stackhpc/2025.1') ||
(github.ref == 'refs/heads/stackhpc/2025.1') ||
(github.base_ref == 'stackhpc/master') ||
(github.ref == 'refs/heads/stackhpc/master')
}}
is-primarily-python312:
- ${{
}}
PEP8_8: ${{
(github.base_ref == 'stackhpc/yoga') ||
(github.ref == 'refs/heads/stackhpc/yoga')
}}
PEP8_10: ${{
(github.base_ref == 'stackhpc/zed') ||
(github.ref == 'refs/heads/stackhpc/zed') ||
(github.base_ref == 'stackhpc/2023.1') ||
(github.ref == 'refs/heads/stackhpc/2023.1') ||
(github.base_ref == 'stackhpc/2024.1') ||
(github.ref == 'refs/heads/stackhpc/2024.1')
}}
PEP8_12: ${{
(github.base_ref == 'stackhpc/2025.1') ||
(github.ref == 'refs/heads/stackhpc/2025.1') ||
(github.base_ref == 'stackhpc/master') ||
(github.ref == 'refs/heads/stackhpc/master')
}}
exclude:
- environment: pep8
python-minor-version: 6
- is-not-python36: true
python-minor-version: 6
- is-not-python36: true
environment: pep8
python-minor-version: 8
- is-not-python36: false
python-minor-version: 10
- is-not-python38: true
python-minor-version: 8
- is-primarily-python312: true
environment: pep8
python-minor-version: 10
- is-primarily-python312: false
python-minor-version: 12
}}
run: |
# Create a matrix based on the environment and Python minor version
output="["
if [[ $PY3_8 == 'true' ]]; then
output+="{'environment': 'py3', 'python-minor-version': 8},"
fi
if [[ $PY3_10 == 'true' ]]; then
output+="{'environment': 'py3', 'python-minor-version': 10},"
fi
if [[ $PY3_12 == 'true' ]]; then
output+="{'environment': 'py3', 'python-minor-version': 12},"
fi
if [[ $PEP8_8 == 'true' ]]; then
output+="{'environment': 'pep8', 'python-minor-version': 8},"
fi
if [[ $PEP8_10 == 'true' ]]; then
output+="{'environment': 'pep8', 'python-minor-version': 10},"
fi
if [[ $PEP8_12 == 'true' ]]; then
output+="{'environment': 'pep8', 'python-minor-version': 12},"
fi
# remove trailing comma
output="${output%,}"
output+="]"
echo "tox-matrix=$output" >> $GITHUB_OUTPUT

tox:
runs-on: ubuntu-latest
needs: define-matrix
strategy:
fail-fast: false
matrix:
include: ${{ fromJSON(needs.define-matrix.outputs.tox-matrix) }}

name: Tox ${{ matrix.environment }} with Python 3.${{ matrix.python-minor-version }}
steps:
Expand Down