Skip to content

Conversation

cityofships
Copy link
Member

@cityofships cityofships commented Sep 3, 2025

Rocky requires some more work to be passing.

@cityofships cityofships requested a review from a team as a code owner September 3, 2025 11:17
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @cityofships, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the continuous integration testing framework by incorporating support for new operating system distributions and a newer Ceph release. It expands the test matrix to include Rocky Linux 9 and Ubuntu Noble, validating Cephadm deployments with both Reef and Squid Ceph releases across different container runtimes. This ensures broader compatibility and stability for future Ceph deployments.

Highlights

  • New OS Support: Introduces new Zuul nodesets for Ubuntu Noble (24.04 LTS) and Rocky Linux 9, significantly expanding the range of operating systems available for Cephadm testing.
  • Expanded Ceph Release Testing: Adds new test jobs to validate Cephadm deployments on Ubuntu Noble with the 'Squid' Ceph release, and on Rocky Linux 9 with both 'Reef' and 'Squid' Ceph releases.
  • Container Engine Coverage: Ensures comprehensive testing by including both Docker and Podman as container engines for the newly added Rocky 9 and Noble test configurations.
  • CI Pipeline Integration: Integrates the new test jobs into the 'check' pipeline for both Noble and Rocky 9 configurations, and specifically the Rocky 9 jobs into the 'gate' pipeline, ensuring these new configurations are automatically tested.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in issue comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds CI jobs for Rocky 9 and Ubuntu Noble with Ceph Squid and Reef releases. The changes are generally good, but there is significant duplication in the new job and nodeset definitions. I've suggested using Zuul's abstract jobs and YAML anchors to improve maintainability. I also noticed that the new Ubuntu Noble jobs are missing from the gate pipeline, which could be an oversight.

@cityofships cityofships force-pushed the squid branch 3 times, most recently from 5f09a9d to e55acc3 Compare September 3, 2025 20:49
@cityofships cityofships changed the title Add Rocky9, Noble and Squid testing Add Noble and Squid testing, prepare Rocky 9 jobs Sep 4, 2025
@cityofships cityofships merged commit aa14250 into master Sep 4, 2025
4 checks passed
@cityofships cityofships deleted the squid branch September 4, 2025 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant