Remove older releases and make Squid default #184
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @cityofships, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request updates the cephadm Ansible collection to align with the latest Ceph releases. It establishes 'Squid' as the new default Ceph version for deployments and removes references to older, no longer supported releases. This ensures the collection remains current and provides a streamlined experience for deploying modern Ceph clusters.
Highlights
- Collection Version Update: The cephadm Ansible collection version has been incremented from 1.20.0 to 1.21.0 in galaxy.yml.
- Default Ceph Release Change: The default Ceph release for deployment has been updated from reef to squid in both the roles/cephadm/README.md documentation and roles/cephadm/defaults/main.yml configuration.
- Deprecation of Older Ceph Releases: Support for older Ceph releases, specifically octopus and pacific, has been removed from the cephadm_ceph_releases variable in roles/cephadm/vars/main.yml.
- Documentation Alignment: Documentation links in roles/ec_profiles/README.md have been updated to point to the squid release documentation for erasure code profiles.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request updates the Ansible collection to make 'Squid' the default Ceph release, replacing 'Reef'. It also removes support for older releases, specifically 'Octopus' and 'Pacific'. The documentation and default variables are updated consistently. The collection version is bumped to 1.21.0. My main feedback is to consider whether a major version bump is more appropriate due to the removal of supported releases, which is a breaking change, and to ensure the changelog is updated accordingly.
No description provided.