Skip to content

Fix prechecks group exist check #186

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Fix prechecks group exist check #186

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
20c7117
Fix prechecks group exist check
darmach Oct 9, 2025
2d7000b
Fix changelog typo
darmach Oct 9, 2025
a54b6b3
Change groups existence check to run once
darmach Oct 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions changelogs/changelog.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -33,3 +33,9 @@ releases:
fragments:
- sudo-fix.yml
release_date: '2025-01-08'
1.19.2:
changes:
bugfixes:
- prechecks - fix groups existing assertion
- prechecks - change groups existence check to run once
release_date: '2025-10-09'
3 changes: 2 additions & 1 deletion roles/cephadm/tasks/prechecks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,8 @@
---
- name: Assert that required Ansible groups exist
run_once: true
ansible.builtin.assert:
that: "'{{ item }}' in group_names"
that: "'{{ item }}' in groups"
msg: "Ansible '{{ item }}' group does not exist - please create one"
loop:
- ceph
Expand Down
Loading