Fix cephadm role Debian Trixie

[TafkaMax]

Fix: https://github.com/stackhpc/ansible-collection-cephadm/blob/master/roles/cephadm/tasks/pkg_debian.yml#L3

[gemini-code-assist]

Summary of Changes

Hello @TafkaMax, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses a compatibility issue within the cephadm Ansible role, specifically concerning Debian Trixie. It modifies a task that cleans up old Ceph keys, making its execution conditional on the Debian major version. This change ensures that the role functions correctly across different Debian releases, preventing unintended operations on newer versions while maintaining support for older ones.

Highlights

• Debian Trixie Compatibility: The cephadm role has been updated to correctly handle Debian Trixie by conditionally executing the apt_key cleanup task only on Debian Bookworm (version 12) or older. This prevents potential issues on newer Debian releases.
• Conditional Key Cleanup: The task responsible for cleaning up old Ceph keys (apt_key with ID E84AC2C0460F3994) now includes a when condition, ensuring it only runs if ansible_distribution_major_version is less than or equal to 12.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[TafkaMax]

Fixes: #190

[gemini-code-assist]

Code Review

This pull request fixes an issue for running the cephadm role on Debian Trixie by adding a condition to a task that uses the deprecated apt_key module. While the change works for Debian, the condition used has the side effect of disabling the task on all Ubuntu versions. I've provided a review comment with a suggested code change to make the condition more robust and explicit for both Debian and Ubuntu, preventing potential issues on older supported Ubuntu releases. I've also suggested simplifying the task name for better readability.