feat: add gitlab role to enable GitLab CI/CD
#29
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jackhodgkiss
force-pushed
the
add-gitlab-role
branch
5 times, most recently
from
9446cfb to
ca2d6d9
Compare
Alex-Welsh
reviewed
Jan 23, 2025
Member
Alex-Welsh
left a comment
Alex-Welsh
left a comment
There was a problem hiding this comment.
A few nitpicks on the readme but otherwise LGTM
Add a new role `gitlab` to enable GitLab CI/CD for use in constructing a CI/CD pipeline that is compatible with `kayobe-automation`. Supports key features and workflows found within the `GitHub` role.
jackhodgkiss
force-pushed
the
add-gitlab-role
branch
from
ca2d6d9 to
8cf9f60
Compare
Alex-Welsh
requested changes
Feb 6, 2025
Alex-Welsh
reviewed
Feb 7, 2025
Co-authored-by: Alex-Welsh <[email protected]>
jackhodgkiss
force-pushed
the
add-gitlab-role
branch
from
a1c5dbe to
89477c6
Compare
Member
|
@jackhodgkiss do you want to move the dynamic hypervisor upgrade work out to another PR so we can get this merged without waiting for more testing? |
* add a a conditional for downstream pipelines * new line
Alex-Welsh
previously approved these changes
May 9, 2025
Member
|
LGTM but I'm not familiar with ansible galaxy versioning. We should bump the version in galaxy.yml but do we need to do so before or after this merges? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new role
gitlabto enable GitLab CI/CD for use in constructing a CI/CD pipeline that is compatible withkayobe-automation.Supports key features and workflows found within the
GitHubrole.