Skip to content

Fix env support in prepare runner #32

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Fix env support in prepare runner #32

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
62e532f
Fix env support in prepare runner
darmach Nov 26, 2025
6d72406
Add missing matrix
darmach Nov 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions roles/github/templates/prepare-runner.yml.j2
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
<%- if github_environment_selector == 'input' and (github_registry.share | default(github_default_registry.share)) is false -%>
<%- set github_runs_on = github_runs_on + ['${{ matrix.environment }}'] -%>
<%- endif -%>
Comment on lines +1 to +3
Copy link

@gemini-code-assist gemini-code-assist bot Nov 26, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The use of ${{ matrix.environment }} on line 2 is incorrect because the prepare-runner job within this reusable workflow does not have a strategy.matrix defined. This will cause the workflow to fail because the matrix context is not available.

Given the intent to use the environment from a workflow input, you should use an input variable. To achieve this, you'll need to:

  1. Declare kayobe_environment as a workflow_call input in this file.
  2. Pass the input from the calling workflow (likely in generic.yml.j2).
  3. Use ${{ inputs.kayobe_environment }} here instead of ${{ matrix.environment }}.

This suggestion corrects the variable, assuming the necessary changes to pass the input will also be made.

<%- if github_environment_selector == 'input' and (github_registry.share | default(github_default_registry.share)) is false -%>
<%- set github_runs_on = github_runs_on + ['${{ inputs.kayobe_environment }}'] -%>
<%- endif -%>

name: %% format_file_name(workflow.file_name, is_title=true) %%

on:
Expand Down
Loading