Adds variables for setting OpenStack region to all resources

[jovial]

Useful in multi-region deployments

[gemini-code-assist]

Summary of Changes

Hello @jovial, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request significantly enhances the flexibility of OpenStack Ansible roles by enabling users to explicitly define the target OpenStack region for various resource management tasks. By introducing a dedicated region name variable for each role and integrating it into the relevant Ansible modules, the changes facilitate more precise control over deployments and operations in multi-region OpenStack environments, without breaking existing configurations.

Highlights

• Region Name Variable Introduction: A new variable, _region_name, has been introduced across multiple OpenStack Ansible roles (e.g., os_container_clusters_region_name, os_deploy_templates_region_name, os_flavors_region_name, os_host_aggregates_region_name, os_images_region_name, os_networks_region_name, os_projects_region_name, os_volumes_region_name).
• Ansible Module Integration: The newly introduced _region_name variables are now utilized as the region_name parameter in various openstack.cloud Ansible modules within their respective task files, allowing users to specify the OpenStack region for operations.
• Documentation Updates: The README.md files for each affected Ansible role have been updated to document the purpose and usage of the new _region_name variable, clarifying its optional nature.
• Default Behavior: The region_name parameter in the Ansible modules defaults to omit if the corresponding _region_name variable is not explicitly set, ensuring backward compatibility and optional region specification.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request does a good job of adding a standardized region_name variable across multiple Ansible roles, which will be very useful for multi-region deployments. The changes are mostly consistent and well-implemented.

However, I've found a few issues:

• In the os_images role, the new region_name parameter is added alongside an existing one, creating a duplicate key in several tasks. This is a critical issue that needs to be fixed.
• In the os_projects role, there's an inconsistency in the variable naming for the region, which could lead to confusion and incorrect configuration.
• The new variable os_volumes_region_name for the os_volumes role is not documented in its README file. Please add documentation for it.

I've left specific comments with suggestions on how to address these points. Once these are resolved, this will be a great addition.

[JohnGarbutt]

That looks correct to me.