Skip to content

Conversation

jovial
Copy link
Contributor

@jovial jovial commented Sep 16, 2025

Can be useful for LDAP users, where you do no wish to create them, but you do want to assign roles.

@jovial jovial requested a review from a team as a code owner September 16, 2025 09:55
Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Summary of Changes

Hello @jovial, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request enhances user management within projects by introducing an optional create_user parameter. This new flag provides flexibility to control whether a user should be created by the system or if their creation should be bypassed, which is especially useful for integrating with external identity management systems like LDAP where users are pre-existing and the primary need is to assign roles. The change updates both the documentation and the user creation task to implement this conditional logic.

Highlights

  • New create_user option: Introduced an optional create_user boolean parameter for project users, allowing for conditional user creation or skipping.
  • Conditional user creation logic: The user creation task in users.yml now includes a when condition. User creation will proceed if create_user is not defined or set to false. If create_user is set to true, the user creation task will be skipped.
  • LDAP integration support: This feature is particularly useful for environments where users are managed externally, such as through LDAP, and the system only needs to assign roles without creating the user.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds a create_user option to allow skipping user creation, which is a useful feature for environments with externally managed users (e.g., LDAP). While the documentation update in the README is clear, the implementation in the Ansible task has a critical logic error. The conditional logic for user creation is inverted, meaning users are created when they should be skipped and vice-versa. I have provided a review comment with a suggested fix to correct this behavior.

@jovial jovial force-pushed the feature/create_user branch from 103c274 to b70a0c0 Compare September 16, 2025 09:59
Can be useful for LDAP users, where you do no wish to create them, but
you do want to assign roles.
@jovial jovial force-pushed the feature/create_user branch from b70a0c0 to e0c1bea Compare September 16, 2025 10:01
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cool, useful for federated users too.

@jovial jovial merged commit 9da93fb into main Sep 17, 2025
4 checks passed
@jovial jovial deleted the feature/create_user branch September 17, 2025 08:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants