Skip to content

Unset all upper constraints files #72

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Unset all upper constraints files #72

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion roles/os_container_clusters/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@ os_container_clusters_auth: {}
# mapping container cluster template attribute names to their values.
os_container_clusters_templates: []
# Upper constraints file for installation of python dependencies.
os_container_clusters_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_container_clusters_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_container_clusters_upper_constraints_file: ""

# Whether to make templates public
os_container_clusters_public: false
# Whether to hide templates by default
Expand Down
2 changes: 1 addition & 1 deletion roles/os_deploy_templates/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
os_deploy_templates_venv:

# Upper constraints file for installation of Python dependencies.
os_deploy_templates_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_deploy_templates_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_deploy_templates_upper_constraints_file: ""


# Authentication type.
os_deploy_templates_auth_type:
Expand Down
2 changes: 1 addition & 1 deletion roles/os_images/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ os_images_dib_venv: "{{ os_images_venv }}"
os_images_package_state: present

# Use Caracal upper constraints
os_images_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_images_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with os_images_dib_upper_constraints_file in this same file, it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style.

os_images_upper_constraints_file: ""


# Upper constraints file for installation of DIB to build images.
os_images_dib_upper_constraints_file: ""
Expand Down
2 changes: 1 addition & 1 deletion roles/os_networks/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -102,4 +102,4 @@ os_networks_security_groups: []
os_networks_rbac: []

# Upper constraints file for installation of Python dependencies.
os_networks_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_networks_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_networks_upper_constraints_file: ""

2 changes: 1 addition & 1 deletion roles/os_openstackclient/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,4 +14,4 @@ os_openstackclient_state: present
# Version of python-openstackclient to install, or unrestricted if empty.
os_openstackclient_version:
# Upper constraints file for installation of openstackclient.
os_openstackclient_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_openstackclient_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_openstackclient_upper_constraints_file: ""

2 changes: 1 addition & 1 deletion roles/os_openstacksdk/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,4 +15,4 @@ os_openstacksdk_state: present
# Version of openstacksdk to install, or unrestricted if empty.
os_openstacksdk_version:
# Upper constraints file for installation of openstacksdk.
os_openstacksdk_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_openstacksdk_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_openstacksdk_upper_constraints_file: ""

1 change: 0 additions & 1 deletion roles/os_projects/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,6 @@ resources.
roles:
- role: stackhpc.openstack.os_projects
os_projects_venv: "~/os-projects-venv"
os_projects_upper_constraints_file: "https://releases.openstack.org/constraints/upper/2024.1"
os_projects_auth_type: "password"
os_projects_auth:
project_name: <keystone project>
Expand Down
2 changes: 1 addition & 1 deletion roles/os_projects/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,4 +38,4 @@ os_projects_domains: []
# - 'public_key_file': Path to the SSH public key on the control host.
# 'quotas': Optional dict mapping quota names to their values.
os_projects: [] # noqa var-naming[no-role-prefix]
os_projects_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_projects_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_projects_upper_constraints_file: ""

2 changes: 1 addition & 1 deletion roles/os_ratings/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Path to a directory in which to create a virtualenv.
os_ratings_venv:
# Upper constraints file for installation of Python dependencies.
os_ratings_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_ratings_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_ratings_upper_constraints_file: ""


# Environment variables for use with OpenStack CLI.
os_ratings_environment: {}
Expand Down
2 changes: 1 addition & 1 deletion roles/os_volumes/defaults/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,4 +34,4 @@ os_volumes: [] # noqa: var-naming[no-role-prefix]
os_volumes_types: []

# A file or URL containing Python upper constraints.
os_volumes_upper_constraints_file: https://releases.openstack.org/constraints/upper/2024.1
os_volumes_upper_constraints_file:
Copy link

@gemini-code-assist gemini-code-assist bot Oct 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

For consistency with other variables in the collection (e.g., os_images_dib_upper_constraints_file in roles/os_images/defaults/main.yml), it would be better to explicitly set this to an empty string ("") rather than null (which is what an empty value becomes in YAML). This makes the intent clearer and maintains a consistent style across the roles.

os_volumes_upper_constraints_file: ""