Skip to content

Improve Slurm cgroup.conf support #195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 29, 2025
Merged

Improve Slurm cgroup.conf support #195

merged 2 commits into from
Jul 29, 2025

Conversation

priteau
Copy link
Member

@priteau priteau commented Jul 23, 2025 •
edited
Loading

  • Support defining custom cgroup.conf options
  • Restart Slurm if cgroup.conf has changed

@priteau priteau self-assigned this Jul 23, 2025
@priteau priteau requested a review from a team as a code owner July 23, 2025 07:57
@priteau priteau changed the title Support defining custom cgroup.conf options Improve Slurm cgroup.conf support Jul 23, 2025
@priteau priteau force-pushed the custom-cgroup-config branch from 1c1be7a to cfbc4fd Compare July 24, 2025 11:20
sjpb
sjpb reviewed Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, pending offline comment whether this should literally just be openhpc_cgroup_config which is a multiline string.

@sjpb sjpb self-requested a review July 29, 2025 12:06
sjpb
sjpb approved these changes Jul 29, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit a28eba7 into master Jul 29, 2025
57 of 58 checks passed
@sjpb sjpb deleted the custom-cgroup-config branch July 29, 2025 12:08
@sjpb sjpb mentioned this pull request Sep 17, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees

@priteau priteau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priteau @sjpb