Skip to content

Fix nightly images getting timestamp/git hash #493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 13, 2024
Merged

Fix nightly images getting timestamp/git hash #493

merged 1 commit into from
Dec 13, 2024

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Dec 12, 2024

Tested locally

@wtripp180901 wtripp180901 marked this pull request as ready for review December 12, 2024 16:39
@wtripp180901 wtripp180901 requested a review from a team as a code owner December 12, 2024 16:39
@wtripp180901 wtripp180901 self-requested a review December 12, 2024 16:39
wtripp180901
wtripp180901 approved these changes Dec 12, 2024
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 5a082e7 into main Dec 13, 2024
2 checks passed
@sjpb sjpb deleted the fix/nightly-img-version branch December 13, 2024 10:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wtripp180901 wtripp180901 wtripp180901 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sjpb @wtripp180901