Skip to content

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 9, 2025

Relevant variables were not passed in to compute module.

Tested:

  • setting volume_backed_instances and root_volume_size just for one compute group
  • setting volume_backed_instances at top-level and non-default root_volume_size for one compute group

Note CI does not test this so can be merged without that passing.

@sjpb sjpb requested a review from a team as a code owner January 9, 2025 10:14
wtripp180901
wtripp180901 previously approved these changes Jan 9, 2025
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 6929272 into main Jan 9, 2025
1 of 2 checks passed
@sjpb sjpb deleted the fix/vol-backed-compute branch January 9, 2025 11:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants