Skip to content

Fix squid/dnf ordering problem #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 22, 2025
Merged

Fix squid/dnf ordering problem #546

merged 2 commits into from
Jan 22, 2025

Conversation

sjpb
Copy link
Collaborator

@sjpb sjpb commented Jan 22, 2025 •
edited
Loading

Fix dependency cycle between squid and dnf_repos:

  • Running squid role may require working dnf repos in order to install packages
  • Running dnf_repos role requires working dnf connectivity in order to install epel-release package
    Without this fix, nodes which were proxied via squid could not run the dnf_repos task because squid was not yet set up.

@sjpb sjpb requested a review from a team as a code owner January 22, 2025 11:44
@sjpb
Copy link
Collaborator Author

sjpb commented Jan 22, 2025

Image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12907491449

@sjpb
Copy link
Collaborator Author

sjpb commented Jan 22, 2025

Image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/12907561745

sd109
sd109 previously approved these changes Jan 22, 2025
View reviewed changes
Copy link
Member

@sd109 sd109 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb requested a review from sd109 January 22, 2025 12:55
@wtripp180901 wtripp180901 self-requested a review January 22, 2025 14:50
wtripp180901
wtripp180901 approved these changes Jan 22, 2025
View reviewed changes
Copy link
Contributor

@wtripp180901 wtripp180901 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 14cfa95 into main Jan 22, 2025
7 checks passed
@sjpb sjpb deleted the fix/squid-dnf branch January 22, 2025 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@wtripp180901 wtripp180901 wtripp180901 approved these changes

@sd109 sd109 Awaiting requested review from sd109

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjpb @sd109 @wtripp180901