Skip to content

Enable lustre in compute-init #581

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 4, 2025
Merged

Enable lustre in compute-init #581

merged 2 commits into from
Mar 4, 2025

Conversation

bertiethorpe
Copy link
Member

No description provided.

@bertiethorpe bertiethorpe marked this pull request as ready for review February 17, 2025 12:11
@bertiethorpe bertiethorpe requested a review from a team as a code owner February 17, 2025 12:11
@bertiethorpe bertiethorpe requested a review from jovial February 17, 2025 12:11
jovial
jovial previously approved these changes Feb 25, 2025
View reviewed changes
@sjpb sjpb mentioned this pull request Feb 28, 2025
Closed
@bertiethorpe bertiethorpe force-pushed the feat/lustre-compute-init branch from f3aa9a3 to 9953a03 Compare March 4, 2025 10:55
@sjpb sjpb self-requested a review March 4, 2025 11:14
sjpb
sjpb approved these changes Mar 4, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Previously approved before rebase after testing at client. Not rebuilding image to include modified compute-init.yml playbook as a custom image is required to add the lustre client anyway.

@sjpb sjpb merged commit 8dc121a into main Mar 4, 2025
2 checks passed
@sjpb sjpb deleted the feat/lustre-compute-init branch March 4, 2025 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

@jovial jovial jovial left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bertiethorpe @jovial @sjpb