Fix basic_users not modifying default nfs-shared home correctly #590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MaxBed4d
approved these changes
Feb 21, 2025
JohnGarbutt
approved these changes
Feb 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where basic_users doesn't always modify /home correctly (i.e. create user home dirs and create/accept ssh keys) for the default NFS configuration, because the control node does not mount /home and might end up being the first host in the play and therefore running these tasks.
This has never been noticed because
a) this aspect of the demo_user isn't tested in CI
b) the caas environment does mount /home on the control node (to provide access to that to allow modification of packages etc across the cluster)
Also changes the default type of the created in-cluster ssh key from rsa to ed25519.