Skip to content

Support disabling port security #592

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 25, 2025
Merged

Support disabling port security #592

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion environments/skeleton/{{cookiecutter.environment}}/tofu/control.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,8 @@ resource "openstack_networking_port_v2" "control" {
subnet_id = data.openstack_networking_subnet_v2.cluster_subnet[each.key].id
}

security_group_ids = [for o in data.openstack_networking_secgroup_v2.nonlogin: o.id]
port_security_enabled = lookup(each.value, "port_security_enabled", true)
security_group_ids = lookup(each.value, "port_security_enabled", true) ? [for o in data.openstack_networking_secgroup_v2.nonlogin: o.id] : []

binding {
vnic_type = lookup(var.vnic_types, each.key, "normal")
Expand Down
3 changes: 2 additions & 1 deletion environments/skeleton/{{cookiecutter.environment}}/tofu/node_group/nodes.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ resource "openstack_networking_port_v2" "compute" {
subnet_id = data.openstack_networking_subnet_v2.subnet[each.value.network].id
}

security_group_ids = var.security_group_ids
port_security_enabled = lookup(each.value, "port_security_enabled", true)
security_group_ids = lookup(each.value, "port_security_enabled", true) ? var.security_group_ids : []

binding {
vnic_type = lookup(var.vnic_types, each.value.network, "normal")
Expand Down
5 changes: 3 additions & 2 deletions environments/skeleton/{{cookiecutter.environment}}/tofu/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,9 @@ variable "cluster_networks" {
type = list(map(string))
description = <<-EOT
List of mappings defining networks. Mapping key/values:
network: Name of existing network
subnet: Name of existing subnet
network: Required. Name of existing network
subnet: Required. Name of existing subnet
port_security_enabled: Optional. Bool, default true
EOT
}

Expand Down
Loading