Allow modifying nodes fully-qualified name #651
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sjpb
force-pushed
the
feat/cluster-nodename-template
branch
from
f71dcdb to
3694bb6
Compare
sjpb
force-pushed
the
feat/cluster-nodename-template
branch
from
3694bb6 to
ad86692
Compare
MoteHue
previously approved these changes
May 7, 2025
sjpb
force-pushed
the
feat/cluster-nodename-template
branch
from
5e12901 to
c42349e
Compare
|
I accidently pushed a commit to this branch, sorry |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds an opentofu variable
cluster_nodename_templateplus overridesnodename_templatefor compute and login node groups, to allow defining the fully-qualified hostname for all nodes.Note the appliance (and roles it uses) assume that the short hostname is resolvable (normally ensured by
etc_hostsrole), and that this matches the Ansibleinventory_hostnameand the slurm node name.