Skip to content

Fix fatimage build without alertmanager secret #655

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 24, 2025
Merged

Fix fatimage build without alertmanager secret #655

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b61e2f1
fix fatimage build without secrets
sjpb Apr 23, 2025
6225b7f
bump CI image
sjpb Apr 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions environments/.stackhpc/tofu/cluster_image.auto.tfvars.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"cluster_image": {
"RL8": "openhpc-RL8-250422-1328-1a6eff86",
"RL9": "openhpc-RL9-250422-1328-1a6eff86"
"RL8": "openhpc-RL8-250423-1606-b61e2f1a",
"RL9": "openhpc-RL9-250423-1606-b61e2f1a"
}
}
4 changes: 3 additions & 1 deletion environments/common/inventory/group_vars/all/prometheus.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,9 @@ prometheus_alertmanager_config_default:
- "{{ alertmanager_address }}:{{ alertmanager_port }}"
basic_auth:
username: alertmanager
password: "{{ vault_alertmanager_admin_password }}"
# cloudalchemy.prometheus/preflight checks this config so it must be
# templatable even during build when it is not used
password: "{{ vault_alertmanager_admin_password | default('UNDEFINED') }}"

prometheus_alertmanager_config_extra: []
prometheus_alertmanager_config: "{{ (prometheus_alertmanager_config_default if groups['alertmanager'] else []) + prometheus_alertmanager_config_extra }}"
Expand Down