Skip to content

Conversation

priteau
Copy link
Member

@priteau priteau commented Jul 3, 2025

No description provided.

@priteau priteau self-assigned this Jul 3, 2025
@priteau priteau force-pushed the inventory-login-subgroup branch from a14c1d9 to f1773ad Compare September 17, 2025 13:25
@priteau priteau changed the title [WIP] Create login subgroups in Ansible inventory Define login subgroups in Ansible inventory Sep 17, 2025
@priteau priteau marked this pull request as ready for review September 17, 2025 13:25
@priteau priteau requested a review from a team as a code owner September 17, 2025 13:25
It resolves some limitations with login subgroups, such as difficulty to
bind the Open OnDemand service to a specific node when naming of the
nodes is not predictable.

This replicates what is already done for compute subgroups.
@priteau priteau force-pushed the inventory-login-subgroup branch from f1773ad to 7dab27b Compare September 18, 2025 11:50
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now we've got top-level groups I think we probably need to do some validation that node group names are unique across login and compute vars, and aren't themselves "login" or "compute", but we can add that later.

@sjpb sjpb merged commit fad0ff4 into main Sep 18, 2025
31 checks passed
@sjpb sjpb deleted the inventory-login-subgroup branch September 18, 2025 13:57
@sjpb sjpb mentioned this pull request Sep 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants