Enable linting #732
Merged
Enable linting #732
+5,025
−4,013
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The super-linter.env currently has the following additions that are to be addressed in the future: VALIDATE_GITHUB_ACTIONS=false VALIDATE_SHELL_SHFMT=false VALIDATE_YAML=false Most of the linting for the above has been addressed with just a single issue remaining that blocks the linter from being enabled.
… comment "need login shell for module command" and mask ansible-lint error
…n focus on the stackhpc.yml workflow
…they're all being triggered from main.yml which has its own concurrency check - the trivscan concurrency was also killing stackhpc
…-lint --fix, it's not required by the linter.
sjpb
requested changes
Sep 17, 2025
maxstack
force-pushed
the
ci/enable-linting
branch
4 times, most recently
from
5e67fc5 to
687c219
Compare
…t inadvertently break any existing checkouts. Direct ansible-lint to use .ansible/collections so downloads are excluded from linting by our .ansible-lint.yml
maxstack
force-pushed
the
ci/enable-linting
branch
from
687c219 to
930223f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
ansible-lintandsuper-linterto the Github PR workflow and fix all linting issues.Push and pull requests trigger a new
main.ymlworkflow responsible for running the linter.The original
extra.yml,stackhpc.yml, andtrivyscan.ymlworkflows are now triggered from the main workflow, only if linting completes successfully.The original workflows can also be triggered manually.