-
Notifications
You must be signed in to change notification settings - Fork 38
Move cookiecutter Tofu to new site environment #751
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
sjpb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few comments, looks structurally sound though!
Co-authored-by: Steve Brasier <[email protected]>
sjpb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Typo, query, no need to rerun CI.
Co-authored-by: Steve Brasier <[email protected]>
|
looks like it has here https://github.com/stackhpc/ansible-slurm-appliance/blob/feat/site-tofu/cookiecutter/%7B%7Bcookiecutter.environment%7D%7D/ansible.cfg, probably some github diff weirdness |
sjpb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
From merge test:
- topology: lets remove from site/groups, and add a note in production to say consider turning this on if cluster is VMs AND its either in one AZ or AZ is configured by rack, and point to docs.
Other than that looks fine
sjpb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
siteenvironment to serve as a base environment for all new cookiecutter environments by default.siteto receive upgrades from the upstream Tofu../environments/skeletonto./cookiecutter.environments/common/layouts, theeverythingtemplates is now thegroupsfile of the site environment.siteas a "parent" in their ansible.cfg by default. Their Tofu configuration is a module pointing at thesiteTofu and they no longer define agroupsfile (deferred tosite)..stackhpcenvironment now based on thesiteenvironment.Note: topology aware scheduling is also now off by default, guidance on re-enabling has been added to the production docs
Warning
Will cause merge conflicts with existing
siteenvironments. To resolve:environments/site/tofu/variables.tf, changes should generally be rejectedenvironments/site/tofushould generally be accepted (unless site specific resources have previously been defined)environments/site/inventory/group_vars/allshould be your existing yaml files:childrenof existing groups inenvironments/site/inventory/groupsshould generally be rejected. New groups which have been added should generally be accepted, unless the feature the group enables is not desired