Skip to content

Allow setting volume type for node group extra_volumes parameter #755

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 12, 2025
Merged

Allow setting volume type for node group extra_volumes parameter #755

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3013f0
allow setting volume type for extra_volumes
sjpb Aug 7, 2025
dbaaa96
Merge branch 'main' into feat/compute-volume-type
sjpb Aug 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions environments/site/tofu/node_group/nodes.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@ resource "openstack_blockstorage_volume_v3" "compute" {
name = "${var.cluster_name}-${each.key}"
description = "Compute node ${each.value.node} volume ${each.value.volume}"
size = var.extra_volumes[each.value.volume].size
volume_type = var.extra_volumes[each.value.volume].volume_type
}

resource "openstack_compute_volume_attach_v2" "compute" {
Expand Down
2 changes: 2 additions & 0 deletions environments/site/tofu/node_group/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,11 +60,13 @@ variable "extra_volumes" {
Keys are unique volume name.
Values are a mapping with:
size: Size of volume in GB
volume_type: Optional. Type of volume, or cloud default
**NB**: The order in /dev is not guaranteed to match the mapping
EOF
type = map(
object({
size = number
volume_type = optional(string)
})
)
default = {}
Expand Down
8 changes: 5 additions & 3 deletions environments/site/tofu/variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -65,10 +65,11 @@ variable "login" {
volume_backed_instances: Overrides variable volume_backed_instances
root_volume_size: Overrides variable root_volume_size
extra_volumes: Mapping defining additional volumes to create and attach
Keys are unique volume name.
Values are a mapping with:
Keys are unique volume name.
Values are a mapping with:
size: Size of volume in GB
**NB**: The order in /dev is not guaranteed to match the mapping
volume_type: Optional. Type of volume, or cloud default
**NB**: The order in /dev is not guaranteed to match the mapping
fip_addresses: List of addresses of floating IPs to associate with
nodes, in the same order as nodes parameter. The
floating IPs must already be allocated to the project.
Expand Down Expand Up @@ -117,6 +118,7 @@ variable "compute" {
Keys are unique volume name.
Values are a mapping with:
size: Size of volume in GB
volume_type: Optional. Type of volume, or cloud default
**NB**: The order in /dev is not guaranteed to match the mapping
ip_addresses: Mapping of list of fixed IP addresses for nodes, keyed
by network name, in same order as nodes parameter.
Expand Down
Loading