Skip to content

Conversation

bertiethorpe
Copy link
Member

@bertiethorpe bertiethorpe commented Sep 8, 2025

CaaS env now inherits from both common and site envs

As a result of this we hit a problem where alertmanager is now turned on by default but there’s no secret for it. Also secret is added to persist_openhpc_secrets.

Aligning CaaS to site also re-raises the issue of CaaS secrets not being idempotent. This is resolved by:

@bertiethorpe bertiethorpe requested a review from a team as a code owner September 8, 2025 16:03
@bertiethorpe
Copy link
Member Author

@bertiethorpe bertiethorpe changed the title Make CaaS inherit from new site env and make persist_openhpc_secrets idempotent Make CaaS specific role: persist_openhpc_secrets idempotent Sep 8, 2025
Copy link
Member

@JohnGarbutt JohnGarbutt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems like the least invasive fix, to get Azimuth working again.

But I would like to see what Steve thinks before we merge this.

@sjpb
Copy link
Collaborator

sjpb commented Sep 9, 2025

@bertiethorpe have you checked this is idempotent too? I.e. if you create a caas cluster, check the secrets, then patch it, do secrets definitely not get changed??

@bertiethorpe
Copy link
Member Author

Tested fully now so going to go ahead and merge

@bertiethorpe bertiethorpe merged commit bc0c66c into main Sep 9, 2025
3 of 4 checks passed
@bertiethorpe bertiethorpe deleted the fix/caas-secrets branch September 9, 2025 23:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants