Skip to content

Expose vgpu group in site inventory #786

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 18, 2025
Merged

Expose vgpu group in site inventory #786

merged 2 commits into from
Sep 18, 2025

Conversation

priteau
Copy link
Member

@priteau priteau commented Sep 17, 2025

Also fix various comments in Ansible group files.

@priteau priteau self-assigned this Sep 17, 2025
@priteau priteau requested a review from a team as a code owner September 17, 2025 13:17
sjpb
sjpb requested changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Can the vgpu group also be added to environments/common/groups please? Generally that file should be the "source of truth" for what groups exist.

Yes, there would be an argument for unduplicating common and site groups, but it is what it is ...

@priteau
Copy link
Member Author

priteau commented Sep 18, 2025

Good catch. Can the vgpu group also be added to environments/common/groups please? Generally that file should be the "source of truth" for what groups exist.

Yes, there would be an argument for unduplicating common and site groups, but it is what it is ...

The vgpu group is already in environments/common/inventory/groups, I copied it from there.

@priteau priteau force-pushed the inventory-group-fixes branch from 02ccf57 to 909451d Compare September 18, 2025 17:09
@priteau priteau requested a review from sjpb September 18, 2025 17:09
sjpb
sjpb approved these changes Sep 18, 2025
View reviewed changes
Copy link
Collaborator

@sjpb sjpb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sjpb sjpb merged commit 06857df into main Sep 18, 2025
31 checks passed
@sjpb sjpb deleted the inventory-group-fixes branch September 18, 2025 17:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sjpb sjpb sjpb approved these changes

Assignees

@priteau priteau

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@priteau @sjpb