-
Notifications
You must be signed in to change notification settings - Fork 35
Improve build group definitions #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
sjpb
wants to merge
9
commits into
feat/root-mdadm
Choose a base branch
from
feat/minimal-extrabuilds
base: feat/root-mdadm
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+156
−63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ff87ef8
to
6ab7255
Compare
Fat image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/17802381929 failed on RL8: maybe repos are messed up? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO: Make sure the docs are really clear so people don't start doing fatimage builds instead of extrabuilds by accident, maybe lead with extrabuilds
TODO: Validate on inventory_groups to ensure it never contains control/login/compute??
This PR reorganises configuration of build VM inventory groups:
inventory_groups
variable, rather than also havingbuilder
as a child of groups inenvironments/{common,site}/inventory/groups
.fatimage
is defined, and added as a child of groups in thesite
groups file, to define the default functionality enabled for fat image builds.dnf_repos
group is only added when required.This fixes a number of issues:
a. Ark credentials are not always required (because
dnf_repos
role is no longer unconditionally enabled)b. The
gateway
role does not re-run unnecessarily.site
groups file.