-
Notifications
You must be signed in to change notification settings - Fork 35
Improve build group definitions #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
ff87ef8
to
6ab7255
Compare
Fat image build: https://github.com/stackhpc/ansible-slurm-appliance/actions/runs/17802381929 failed on RL8: maybe repos are messed up? |
876787e
to
480336e
Compare
f90c1da
to
876787e
Compare
…e-slurm-appliance into feat/minimal-extrabuilds
…ally into feat/minimal-extrabuilds
Inventory groups in extrabuild runs above:
RL9:
Looks OK |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. This is a much clearer way of doing extra builds imo!
This PR reorganises configuration of build VM inventory groups and improves image build documentation:
inventory_groups
variable, rather than also havingbuilder
as a child of groups inenvironments/{common,site}/inventory/groups
.fatimage
is defined, and added as a child of groups in thesite
groups file, to define the default functionality enabled for fat image builds.dnf_repos
group is only added when required.This fixes a number of issues:
a. Ark credentials are not always required (because
dnf_repos
role is no longer unconditionally enabled)b. The
gateway
role does not re-run unnecessarily during a non-stackhpc extra buildc. The
sssd
,tuned
,squid
andraid
roles do not re-run unecessarily during a stackhpc extra buildsite
groups file.