Skip to content

Commit a9dc56f

Browse files
committed
Fix leading and trailing whitespace in inspection_callback_url
This was templating as: " https://1.2.3.4:5050/v1/continue ". We can remove this using the whitespace control modifiers from jinja, see: https://jinja.palletsprojects.com/en/3.0.x/templates/#whitespace-control Closes-Bug: #2072550 Change-Id: I45be2ddfb48004c9b880bd4b4627b2cf26a83616
1 parent cebecff commit a9dc56f

File tree

2 files changed

+11
-3
lines changed

2 files changed

+11
-3
lines changed

playbooks/roles/bifrost-ironic-install/tasks/create_tftpboot.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -184,8 +184,8 @@
184184
mode: "0644"
185185
vars:
186186
inspection_callback_url: >-
187-
{% if enable_inspector | bool %}
187+
{%- if enable_inspector | bool -%}
188188
{{ api_protocol }}://{{ internal_ip }}:5050/v1/continue
189-
{% else %}
189+
{%- else -%}
190190
{{ api_protocol }}://{{ internal_ip }}:6385/v1/continue_inspection
191-
{% endif %}
191+
{%- endif -%}
Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
---
2+
fixes:
3+
- |
4+
Fixes an issue where ``inspection_callback_url`` was templated with leading
5+
whitespace. This caused the ``ipa-inspection-callback-url`` kernel command
6+
line argument to be incorrectly set, leading to Ironic Python Agent posting
7+
introspection data back to Ironic rather than Ironic Inspector when using
8+
the ``enable_inspector`` option.

0 commit comments

Comments
 (0)