Gcbase #41
Open
Gcbase #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m-bull
reviewed
Jun 25, 2025
|
|
||
| # TODO(johngarbutt) look for any during the above allocations | ||
| consumers_query = models.Consumer.objects.filter(account__pk=pk) | ||
| consumers_query = models.Consumer.objects.filter(resource_provider_account__account__pk=pk) |
Contributor
There was a problem hiding this comment.
This has never worked.
Creating and updating an object works - the data exist, but querying these data back again causes a 502.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A few tweaks but the main area that needs work is
class CreditAllocationResourceViewSet(viewsets.ModelViewSet):This crashes out for any query that should also return resource allocations for the given account. The code looks incomplete and appeated to be using the wrong account field for the search.
Also the allocation resource object was not functioning as a single REST object because the creation was done via the allocation object for multiple entries. Consequently a dumb client (such as TF Rest API) cannot create and manage individual resources. The change I made to make it operate with a single item patches this but it might be better to implement a new endpoint