Skip to content

Work around missing interface breaking config diff #10

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

Work around missing interface breaking config diff #10

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
a9b92e7
Work around missing interface breaking config diff
Jun 3, 2021
856d853
Hack in tempest plugin
JohnGarbutt Jun 8, 2021
afe1830
List all registered tests
JohnGarbutt Jun 8, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ansible/roles/config-diff-vars/filter_plugins/utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ def ip_mappings(context, hosts):
continue
result[host] = []
for network in networks:
interface = net_interface(context, host, network)
interface = net_interface(context, host, network) or ("missinginterface" + network)
Copy link
Collaborator

@jovial jovial Jun 3, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
interface = net_interface(context, host, network) or ("missinginterface" + network)
interface = net_interface(context, host, network)
if not interface:
continue

Would also work, but maybe that is less debug-able.

ip = net_ip(context, host, network) or "dhcp.or.missing"
result[host].append({
'interface': interface,
Expand Down