Merge "ansible-lint: Fix command-instead-of-module/shell"

Author: Zuul

.ansible-lint

@@ -37,6 +37,4 @@ skip_list:
   - var-naming[no-role-prefix]
   - risky-file-permissions
   - risky-shell-pipe
-  - command-instead-of-shell
-  - command-instead-of-module
   - yaml[line-length]

ansible/roles/loadbalancer/tasks/config_validate.yml

@@ -2,7 +2,7 @@
 - name: Validating haproxy config files
   vars:
     service: "{{ loadbalancer_services['haproxy'] }}"
-  shell: >-
+  command: >-
     {{ kolla_container_engine }} exec -i haproxy haproxy
     -c -f /etc/haproxy/haproxy.cfg -f /etc/haproxy/services.d/
   register: haproxy_config_validation_result

ansible/roles/valkey/tasks/check.yml

@@ -5,7 +5,7 @@
 
 - name: Valkey ping pong check
   become: true
-  shell: >-
+  command: >-
     {{ kolla_container_engine }} exec valkey_server valkey-cli -h {{ api_interface_address }}
     -a {{ valkey_master_password }} ping
   register: valkey_check

ansible/roles/valkey/tasks/upgrade.yml

@@ -36,7 +36,7 @@
       become: true
       delegate_to: "{{ valkey_master_host }}"
       run_once: true
-      shell: >-
+      command: >-
         {{ kolla_container_engine }} exec valkey_server
         valkey-cli -h {{ api_interface_address }} -p {{ valkey_server_port }} info replication
       register: valkey_replication
@@ -81,7 +81,7 @@
       become: true
       delegate_to: "{{ valkey_master_host }}"
       run_once: true
-      shell: >-
+      command: >-
         {{ kolla_container_engine }} exec valkey_server
         valkey-cli -h {{ api_interface_address }} -p {{ valkey_server_port }} info replication
       register: valkey_role