Synchronise master with upstream

.ansible-lint

@@ -9,9 +9,6 @@ exclude_paths:
 strict: false
 use_default_rules: true
 skip_list:
-  # [unnamed-task] All tasks should be named
-  # FIXME(mgoddard): Add names to all tasks
-  - unnamed-task
   # disable experimental rules
   - experimental
   # NOTE(frickler): Agreed at Zed PTG not to use FQCN for builtin actions for now, due to

ansible/mariadb.yml

@@ -12,7 +12,8 @@
   tags:
     - mariadb
   tasks:
-    - import_role:
+    - name: Apply mariadb role
+      import_role:
         name: mariadb
 
 - name: Restart mariadb services
@@ -29,7 +30,8 @@
   tags:
     - mariadb
   tasks:
-    - import_role:
+    - name: Restart mariadb services
+      import_role:
         name: mariadb
         tasks_from: restart_services.yml
 
@@ -47,7 +49,8 @@
   tags:
     - mariadb
   tasks:
-    - import_role:
+    - name: Start mariadb services
+      import_role:
         name: mariadb
         tasks_from: restart_services.yml
 
@@ -63,7 +66,8 @@
   tags:
     - mariadb
   tasks:
-    - import_role:
+    - name: Restart bootstrap mariadb service
+      import_role:
         name: mariadb
         tasks_from: restart_services.yml
 

ansible/nova-libvirt-cleanup.yml

@@ -14,6 +14,7 @@
   tags:
     - nova-libvirt-cleanup
   tasks:
-    - import_role:
+    - name: Clean up nova libvirt container and configuration
+      import_role:
         name: nova-cell
         tasks_from: libvirt-cleanup.yml

ansible/nova.yml

@@ -164,7 +164,8 @@
        default(kolla_max_fail_percentage) |
        default(100) }}
   tasks:
-    - import_role:
+    - name: Refresh nova scheduler cell cache
+      import_role:
         name: nova
         tasks_from: refresh_scheduler_cell_cache
       when:
@@ -193,7 +194,8 @@
        default(kolla_max_fail_percentage) |
        default(100) }}
   tasks:
-    - import_role:
+    - name: Reload global nova super conductor services
+      import_role:
         name: nova
         tasks_from: reload_super_conductor
       when:
@@ -221,7 +223,8 @@
        default(kolla_max_fail_percentage) |
        default(100) }}
   tasks:
-    - import_role:
+    - name: Reload nova cell services
+      import_role:
         name: nova-cell
         tasks_from: reload
       when:
@@ -245,7 +248,8 @@
        default(kolla_max_fail_percentage) |
        default(100) }}
   tasks:
-    - import_role:
+    - name: Reload nova API services
+      import_role:
         name: nova
         tasks_from: reload_api
       when:
@@ -269,7 +273,8 @@
   # Fail all hosts if any of these once-per-cell tasks fails.
   any_errors_fatal: true
   tasks:
-    - import_role:
+    - name: Run nova API online database migration
+      import_role:
         name: nova
         tasks_from: online_data_migrations
       when:
@@ -294,7 +299,8 @@
   # Fail all hosts if any of these once-per-cell tasks fails.
   any_errors_fatal: true
   tasks:
-    - import_role:
+    - name: Run nova cell online database migrations
+      import_role:
         name: nova-cell
         tasks_from: online_data_migrations
       when:

ansible/post-deploy.yml

@@ -63,7 +63,8 @@
         group: "{{ ansible_facts.user_gid }}"
         mode: "0600"
 
-    - import_role:
+    - name: Template out octavia-openrc.sh
+      import_role:
         name: octavia
         tasks_from: openrc.yml
       vars:

ansible/rabbitmq.yml

@@ -12,7 +12,8 @@
   tags:
     - rabbitmq
   tasks:
-    - import_role:
+    - name: Apply rabbitmq role
+      import_role:
         name: rabbitmq
       vars:
         role_rabbitmq_cluster_cookie: "{{ rabbitmq_cluster_cookie }}"
@@ -41,7 +42,8 @@
   tags:
     - rabbitmq
   tasks:
-    - import_role:
+    - name: Restart rabbitmq services
+      import_role:
         name: rabbitmq
         tasks_from: restart_services.yml
       vars:

ansible/roles/aodh/tasks/bootstrap.yml

@@ -37,4 +37,5 @@
   when:
     - not use_preconfigured_databases | bool
 
-- import_tasks: bootstrap_service.yml
+- name: Run aodh bootstrap container
+  import_tasks: bootstrap_service.yml

ansible/roles/aodh/tasks/check-containers.yml

@@ -1,3 +1,4 @@
 ---
-- import_role:
+- name: Check aodh containers
+  import_role:
     name: service-check-containers

ansible/roles/aodh/tasks/config.yml

@@ -38,7 +38,8 @@
     - aodh_policy_file is defined
   with_dict: "{{ aodh_services | select_services_enabled_and_mapped_to_host }}"
 
-- include_tasks: copy-certs.yml
+- name: Copying over TLS certificates
+  include_tasks: copy-certs.yml
   when:
     - aodh_copy_certs | bool
 

ansible/roles/aodh/tasks/config_validate.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Validate aodh configuration
+  import_role:
     name: service-config-validate
   vars:
     service_config_validate_services: "{{ aodh_services }}"

ansible/roles/aodh/tasks/deploy-containers.yml

@@ -1,2 +1,3 @@
 ---
-- import_tasks: check-containers.yml
+- name: Check aodh containers
+  import_tasks: check-containers.yml

ansible/roles/aodh/tasks/deploy.yml

@@ -1,14 +1,19 @@
 ---
-- import_tasks: register.yml
+- name: Register aodh in Keystone
+  import_tasks: register.yml
 
-- import_tasks: config.yml
+- name: Configure aodh
+  import_tasks: config.yml
 
-- import_tasks: check-containers.yml
+- name: Check aodh containers
+  import_tasks: check-containers.yml
 
-- include_tasks: clone.yml
+- name: Clone aodh repository
+  include_tasks: clone.yml
   when: aodh_dev_mode | bool
 
-- import_tasks: bootstrap.yml
+- name: Bootstrap aodh service
+  import_tasks: bootstrap.yml
 
 - name: Flush handlers
   meta: flush_handlers

ansible/roles/aodh/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: "{{ kolla_action }}.yml"
+- name: "Include tasks for action {{ kolla_action }}"
+  include_tasks: "{{ kolla_action }}.yml"

ansible/roles/aodh/tasks/precheck.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Precheck aodh configuration
+  import_role:
     name: service-precheck
   vars:
     service_precheck_services: "{{ aodh_services }}"

ansible/roles/aodh/tasks/pull.yml

@@ -1,3 +1,4 @@
 ---
-- import_role:
+- name: Pull aodh images
+  import_role:
     role: service-images-pull

ansible/roles/aodh/tasks/reconfigure.yml

@@ -1,2 +1,3 @@
 ---
-- import_tasks: deploy.yml
+- name: Deploy aodh
+  import_tasks: deploy.yml

ansible/roles/aodh/tasks/register.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Register aodh service, endpoints, and users in Keystone
+  import_role:
     name: service-ks-register
   vars:
     service_ks_register_auth: "{{ openstack_aodh_auth }}"

ansible/roles/aodh/tasks/stop.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Stop aodh containers
+  import_role:
     name: service-stop
   vars:
     project_services: "{{ aodh_services }}"

ansible/roles/aodh/tasks/upgrade.yml

@@ -1,9 +1,12 @@
 ---
-- import_tasks: config.yml
+- name: Configure aodh
+  import_tasks: config.yml
 
-- import_tasks: check-containers.yml
+- name: Check aodh containers
+  import_tasks: check-containers.yml
 
-- import_tasks: bootstrap_service.yml
+- name: Run aodh bootstrap container
+  import_tasks: bootstrap_service.yml
 
 - name: Flush handlers
   meta: flush_handlers

ansible/roles/barbican/tasks/bootstrap.yml

@@ -37,4 +37,5 @@
   when:
     - not use_preconfigured_databases | bool
 
-- import_tasks: bootstrap_service.yml
+- name: Run barbican bootstrap container
+  import_tasks: bootstrap_service.yml

ansible/roles/barbican/tasks/check-containers.yml

@@ -1,3 +1,4 @@
 ---
-- import_role:
+- name: Check barbican containers
+  import_role:
     name: service-check-containers

ansible/roles/barbican/tasks/config.yml

@@ -42,7 +42,8 @@
   when:
     - barbican_policy.results | length > 0
 
-- include_tasks: copy-certs.yml
+- name: Copying over TLS certificates
+  include_tasks: copy-certs.yml
   when:
     - barbican_copy_certs | bool
 

ansible/roles/barbican/tasks/config_validate.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Validate barbican configuration
+  import_role:
     name: service-config-validate
   vars:
     service_config_validate_services: "{{ barbican_services }}"

ansible/roles/barbican/tasks/deploy-containers.yml

@@ -1,2 +1,3 @@
 ---
-- import_tasks: check-containers.yml
+- name: Check barbican containers
+  import_tasks: check-containers.yml

ansible/roles/barbican/tasks/deploy.yml

@@ -1,14 +1,19 @@
 ---
-- import_tasks: register.yml
+- name: Register barbican in Keystone
+  import_tasks: register.yml
 
-- import_tasks: config.yml
+- name: Configure barbican
+  import_tasks: config.yml
 
-- import_tasks: check-containers.yml
+- name: Check barbican containers
+  import_tasks: check-containers.yml
 
-- include_tasks: clone.yml
+- name: Clone barbican repository
+  include_tasks: clone.yml
   when: barbican_dev_mode | bool
 
-- import_tasks: bootstrap.yml
+- name: Bootstrap barbican service
+  import_tasks: bootstrap.yml
 
 - name: Flush handlers
   meta: flush_handlers

ansible/roles/barbican/tasks/main.yml

@@ -1,2 +1,3 @@
 ---
-- include_tasks: "{{ kolla_action }}.yml"
+- name: "Include tasks for action {{ kolla_action }}"
+  include_tasks: "{{ kolla_action }}.yml"

ansible/roles/barbican/tasks/precheck.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Precheck barbican configuration
+  import_role:
     name: service-precheck
   vars:
     service_precheck_services: "{{ barbican_services }}"

ansible/roles/barbican/tasks/pull.yml

@@ -1,3 +1,4 @@
 ---
-- import_role:
+- name: Pull barbican images
+  import_role:
     role: service-images-pull

ansible/roles/barbican/tasks/reconfigure.yml

@@ -1,2 +1,3 @@
 ---
-- import_tasks: deploy.yml
+- name: Deploy barbican
+  import_tasks: deploy.yml

ansible/roles/barbican/tasks/register.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Register barbican service, endpoints, and users in Keystone
+  import_role:
     name: service-ks-register
   vars:
     service_ks_register_auth: "{{ openstack_barbican_auth }}"

ansible/roles/barbican/tasks/stop.yml

@@ -1,5 +1,6 @@
 ---
-- import_role:
+- name: Stop barbican containers
+  import_role:
     name: service-stop
   vars:
     project_services: "{{ barbican_services }}"

ansible/roles/barbican/tasks/upgrade.yml

@@ -1,9 +1,12 @@
 ---
-- import_tasks: config.yml
+- name: Configure barbican
+  import_tasks: config.yml
 
-- import_tasks: check-containers.yml
+- name: Check barbican containers
+  import_tasks: check-containers.yml
 
-- import_tasks: bootstrap_service.yml
+- name: Run barbican bootstrap container
+  import_tasks: bootstrap_service.yml
 
 - name: Flush handlers
   meta: flush_handlers

ansible/roles/bifrost/tasks/deploy.yml

@@ -1,6 +1,9 @@
 ---
-- import_tasks: config.yml
+- name: Configure bifrost
+  import_tasks: config.yml
 
-- import_tasks: start.yml
+- name: Start bifrost containers
+  import_tasks: start.yml
 
-- import_tasks: bootstrap.yml
+- name: Bootstrap bifrost service
+  import_tasks: bootstrap.yml