Synchronise 2023.1 with upstream #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=80&v=4){kind=small}
This change refactors prvisep util test cases to account for the fact that oslo.log now conditionally uses an internal pipe mutex when logging under eventlet. This was added by Iac1b0891ae584ce4b95964e6cdc0ff2483a4e57d which is part of oslo.log 5.3.0 As a result we need to mock all calls to oslo.log in unit tests that are assertign if os.write is called. when the internal pipe mutex is used oslo.log calls os.write when the mutex is released. Related-Bug: #1983863 Change-Id: Id313669df80f9190b79690fff25f8e3fce2a4aca (cherry picked from commit ea07f96)
Change-Id: I0da37bb80626f628b742275e28fd98b262533491
github-actions
bot
added
automated
priteau
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of 2023.1 from upstream unmaintained/2023.1.