Skip to content

Commit a92ed84

Browse files
Zuulopenstack-gerrit
authored andcommitted
Merge "tests: Remove obsolete TODO about a fd leak"
2 parents b80b7e9 + 0cdc041 commit a92ed84

File tree

1 file changed

+0
-10
lines changed

1 file changed

+0
-10
lines changed

ovn_octavia_provider/tests/unit/ovsdb/test_impl_idl_ovn.py

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -36,11 +36,6 @@ class TestOvnNbIdlForLb(base.BaseTestCase):
3636
def setUp(self):
3737
super().setUp()
3838
ovn_config.register_opts()
39-
# TODO(haleyb) - figure out why every test in this class generates
40-
# this warning, think it's in relation to reading this schema file:
41-
# sys:1: ResourceWarning: unclosed file <_io.FileIO name=1 mode='wb'
42-
# closefd=True> ResourceWarning: Enable tracemalloc to get the object
43-
# allocation traceback
4439
self.mock_gsh = mock.patch.object(
4540
idlutils, 'get_schema_helper',
4641
side_effect=lambda x, y: ovs_idl.SchemaHelper(
@@ -64,11 +59,6 @@ class TestOvnSbIdlForLb(base.BaseTestCase):
6459
def setUp(self):
6560
super().setUp()
6661
ovn_config.register_opts()
67-
# TODO(haleyb) - figure out why every test in this class generates
68-
# this warning, think it's in relation to reading this schema file:
69-
# sys:1: ResourceWarning: unclosed file <_io.FileIO name=1 mode='wb'
70-
# closefd=True> ResourceWarning: Enable tracemalloc to get the object
71-
# allocation traceback
7262
self.mock_gsh = mock.patch.object(
7363
idlutils, 'get_schema_helper',
7464
side_effect=lambda x, y: ovs_idl.SchemaHelper(

0 commit comments

Comments
 (0)