Skip to content

Conversation

sd109
Copy link
Member

@sd109 sd109 commented Mar 18, 2025

Adds an additional axis field to the request payload and converts the x-activestorage-count response header from a single i64 to a Vec<i64>.

Adapts each reduction operation to explicitly handle each of the three distinct axis options:

  • reductions over all data (i.e. flattened to a 1D array) when request payload does not contain axis key
  • reduction over a single axis when payload contains axis: <int>
  • reduction over multiple axes when payload contains axis: <list-of-ints>

Corresponding changes to the compliance test suite: stackhpc/s3-active-storage-compliance-suite#23

@sd109 sd109 marked this pull request as ready for review March 21, 2025 16:52
@sd109 sd109 requested a review from maxstack March 21, 2025 16:52
@sd109 sd109 merged commit 2740d92 into main Mar 28, 2025
8 checks passed
@sd109 sd109 deleted the feat/reductions-over-axes branch March 28, 2025 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants