forked from openstack/requirements
-
Notifications
You must be signed in to change notification settings - Fork 0
Synchronise master with upstream #142
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
github-actions
wants to merge
63
commits into
stackhpc/master
Choose a base branch
from
upstream/master-2025-11-24
base: stackhpc/master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At least part of it anyway. Rather than waiting to split the lines and strip the non-dependency information (comments etc) from the file, we do it immediately on load. We also add a whole lot of type hints to the modified code, to help us reason about things a little easier. Change-Id: Ide4574c53123ebe20d28211b80b9c079d01dd5e0 Signed-off-by: Stephen Finucane <[email protected]>
meta: version: 7.0.3 meta: team: oslo meta: diff-start: - meta: series: independent meta: branch: master meta: release-type: release meta: pypi: yes meta: first: no meta: release:Author: Jeremy Stanley <[email protected]> meta: release:Commit: Jeremy Stanley <[email protected]> meta: release:Change-Id: I80d65f9f4c82ae66a585e5f13ea004bc50d513bb meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Workflow+1: Dr. Jens Harbott <[email protected]> meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> meta: release:Code-Review+1: Stephen Finucane <[email protected]> meta: release:Code-Review+1: Tony Breeds <[email protected]> meta: release:Code-Review+1: Clark Boylan <[email protected]> meta: release:Code-Review+2: Dr. Jens Harbott <[email protected]> Change-Id: I4f91343247366456ee27db2628b9deec28830031 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 6.0.0 meta: team: oslo meta: diff-start: - meta: series: independent meta: branch: master meta: release-type: release meta: pypi: yes meta: first: no meta: release:Author: Stephen Finucane <[email protected]> meta: release:Commit: Stephen Finucane <[email protected]> meta: release:Change-Id: Iab882ee360b072584e5c0c71d699a52d35c6bdfd meta: release:Workflow+1: Elod Illes <[email protected]> meta: release:Code-Review+1: Takashi Kajinami <[email protected]> meta: release:Code-Review+2: Dr. Jens Harbott <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> Change-Id: I6f6a3fd634cddeb162fdaa57e27a784b52756b51 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
UP is the exact name of the rule, instead of U. Use the exact name to avoid potential problems caused by any UX rules which can be added in the future. Change-Id: Ie007e90c3861aa7f289a9a9719e33199cd10efac Signed-off-by: Takashi Kajinami <[email protected]>
meta: version: 6.1.0 meta: team: mistral meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: Ie51423df50429031ce49ce21daffd113289a6384 meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Arnaud Morin <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> Change-Id: I2b42b690d5083169ebb063252e184affa07e991a Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 5.7.0 meta: team: manila meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: Ia76666bfb026b81309413ac4f49b19edf4fb32b0 meta: release:Code-Review+1: Goutham Pacha Ravi <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Carlos Eduardo <[email protected]> Change-Id: Ib05053ed2315b5f101b46be8445d082f6c9ff608 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 7.8.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I53dd5c219667fb587642aca1935cf329e3a59fb7 meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> Change-Id: I14fff21b329d0d79a94dff68afabb3b6d6d91088 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 10.1.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I522b7dc0534b42074552e2b5f6fbdd4af99f4fd6 meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> Change-Id: I90ec769a3adc0389bdcfdede3aba2bdfd44f89c1 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 4.9.0 meta: team: swift meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Tim Burke <[email protected]> meta: release:Change-Id: I313c604b578b56e8ecf24eef0532c5481a8a135a meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Tim Burke <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> Change-Id: I047376a4699c7085f44e76b41365e6d395ff2a0f Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 6.7.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I9e88e9bf2b917d481da58007ffd6048e48b37819 meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> Change-Id: I4f4fca65372efd4f4056189bda1cdb0e288c92ce Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 5.8.0 meta: team: ironic meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: no meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: Ib3b919946c39ecf39552088e3b2246e1e60f68c1 meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Riccardo Pittau <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> Change-Id: I0da77979f41bf2eb1aeb5fbb92fb1ab8ee9d4256 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 4.8.0 meta: team: OpenStackSDK meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I97c9cc9904ff0bb8a96ecb8f25c4180e4c05e2b6 meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+1: Artem Goncharov <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> Change-Id: Ie483142a2722f9a1360fb36a78a7c280de2b1d1f Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 5.5.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: no meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I246dc3637f96ba288a5245ca069158ad676bbbb1 meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Workflow+1: Elod Illes <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> Change-Id: Ia204b190d15bc3d39ced5bd6274e71a79902f801 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 5.14.0 meta: team: ironic meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Riccardo Pittau <[email protected]> meta: release:Change-Id: Ic7f2088392e0d11d2b0eb1c5f2d767d987e58610 meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Workflow+1: Elod Illes <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> Change-Id: I674f38a33b9e3e177c192a5677d0dd2c30bbb62c Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 2.14.0 meta: team: neutron meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: no meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Brian Haley <[email protected]> meta: release:Change-Id: I7e357bd7f71f06db8f9b3c91ba6494733d39e61f meta: release:Workflow+1: Elod Illes <[email protected]> meta: release:Code-Review+1: Lajos Katona <[email protected]> meta: release:Code-Review+1: Brian Haley <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+1: Rodolfo Alonso <[email protected]> Change-Id: Iaf52b5aa6d433bd91a0a0190107629255b5d6d58 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 0.14.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I5a9e7e5744f4964c73fd0291251ff205bd7d1245 meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Workflow+1: Elod Illes <[email protected]> meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> Change-Id: I28b45a3b4f092d344a65eb87c3146afdc16373e5 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 4.4.1 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: no meta: release:Author: Hervé Beraud <[email protected]> meta: release:Commit: Hervé Beraud <[email protected]> meta: release:Change-Id: I09ba108cd5fa1ded9aae42fb3873e5d47db2cd59 meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Balazs Gibizer <[email protected]> Change-Id: I4dd66fc4e2ab375e39280ffcc19d3d3f69ceebed Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 3.9.0 meta: team: Telemetry meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I19d8ceddfa19e30f3e98615dae3bce25773e4a29 meta: release:Code-Review+1: Juan Larriba <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> Change-Id: I93db0942531f4dc155972f6643a453d67cb76add Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 3.5.0 meta: team: mistral meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: I61468bdcdb9c9030c79f2650ddb9779e16291cb0 meta: release:Code-Review+1: Arnaud Morin <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> Change-Id: Ie5136504837b55c6b69f40da0932f83dec57eead Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 4.7.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: Ie68a8c7cd684b3a32631a8c000a5a98da66e6261 meta: release:Code-Review+1: Daniel Bengtsson <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> Change-Id: I19f19eba75359aef59e52fea694f0976d7dbfeaa Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 4.2.0 meta: team: zaqar meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Elod Illes <[email protected]> meta: release:Commit: Elod Illes <[email protected]> meta: release:Change-Id: Ib294e81d440f095b2ee467db885135bcdc3ac709 meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Hao Wang <[email protected]> Change-Id: I9f9fc30def8d0b3bd54d009f08c6f92999aa73db Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 5.6.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Stephen Finucane <[email protected]> meta: release:Commit: Stephen Finucane <[email protected]> meta: release:Change-Id: I13ee392a1fe31c37409f09c431995d8b198837fc meta: release:Workflow+1: Elod Illes <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+2: Hervé Beraud <[email protected]> meta: release:Code-Review+1: Takashi Kajinami <[email protected]> Change-Id: I391eed6051fe73a4b9b04a7f32d1e7699994c19b Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 4.12.0 meta: team: OpenStackSDK meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Stephen Finucane <[email protected]> meta: release:Commit: Stephen Finucane <[email protected]> meta: release:Change-Id: I1c1b3dbc6153644e7d930e09423d6424b12e52d0 meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Artem Goncharov <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> Change-Id: I08ab72e0d53c7f75bcd2409aace3eca482f84e5f Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 6.7.1 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: no meta: release:Author: Stephen Finucane <[email protected]> meta: release:Commit: Stephen Finucane <[email protected]> meta: release:Change-Id: I4f197d9339e982b1def3cef20ab6e637b53bc1f0 meta: release:Code-Review+1: Takashi Kajinami <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> Change-Id: I6de3650af5e21e77cdb2860b0f34c5f9e2823d2a Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 9.2.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Stephen Finucane <[email protected]> meta: release:Commit: Stephen Finucane <[email protected]> meta: release:Change-Id: Ieb7b6f6178552b58d54e1473a550133f2cd58782 meta: release:Code-Review+1: Takashi Kajinami <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Workflow+1: Thierry Carrez <[email protected]> Change-Id: I0a23ed7ff2c01bf9557bf3b642a1852ce5ccaf5d Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 6.2.0 meta: team: oslo meta: diff-start: - meta: series: gazpacho meta: branch: master meta: release-type: release meta: pypi: yes meta: first: yes meta: release:Author: Stephen Finucane <[email protected]> meta: release:Commit: Stephen Finucane <[email protected]> meta: release:Change-Id: I3115fa6436cd47057d891833df4804f1ae29a0a8 meta: release:Workflow+1: Thierry Carrez <[email protected]> meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+1: Takashi Kajinami <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> Change-Id: I31699f0b8a20c6e1b55de2d57e8392196e000da5 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
meta: version: 1.8.2 meta: team: OpenStackSDK meta: diff-start: - meta: series: independent meta: branch: master meta: release-type: release meta: pypi: yes meta: first: no meta: release:Author: Stephen Finucane <[email protected]> meta: release:Commit: Stephen Finucane <[email protected]> meta: release:Change-Id: I0d149b5ca22489d248edd64e5e6505776a3f10ef meta: release:Code-Review+2: Elod Illes <[email protected]> meta: release:Code-Review+2: Thierry Carrez <[email protected]> meta: release:Code-Review+1: Artem Goncharov <[email protected]> meta: release:Workflow+1: Elod Illes <[email protected]> Change-Id: I10b662a41cd37552cf3cef350ec3ea4a97900472 Signed-off-by: OpenStack Proposal Bot <[email protected]> Generated-By: openstack/project-config:roles/copy-release-tools-scripts/files/release-tools/update_constraints.sh
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains a snapshot of master from upstream master.