Skip to content

Commit 8075a1a

Browse files
sd109SkylerMalinowski
authored andcommitted
feat: unset default storage class in chart values
The correct way to specify a default storage class in Kubernetes is via the `storageclass.kubernetes.io/is-default-class` annotation [1] rather than assuming a storage class named 'standard' exists. [1] https://kubernetes.io/docs/concepts/storage/storage-classes/#default-storageclass Signed-off-by: sd109 <[email protected]>
1 parent 44b7909 commit 8075a1a

File tree

3 files changed

+7
-5
lines changed

3 files changed

+7
-5
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -13,4 +13,6 @@ All notable changes to this project will be documented in this file.
1313

1414
### Changed
1515

16+
- Changed default storageClassName to empty.
17+
1618
### Removed

helm/slurm/README.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ Helm Chart for Slurm HPC Workload Manager
8181
| controller.persistence.labels | object | `{}` | Create a `PersistentVolumeClaim` with these labels. |
8282
| controller.persistence.selector | object | `{}` | Selector to match an existing `PersistentVolume`. |
8383
| controller.persistence.size | string | `"4Gi"` | Create a `PersistentVolumeClaim` with this storage size. |
84-
| controller.persistence.storageClass | string | `"standard"` | Create a `PersistentVolumeClaim` with this storage class. |
84+
| controller.persistence.storageClass | string | `nil` | Create a `PersistentVolumeClaim` with this storage class. |
8585
| controller.priorityClassName | string | `""` | Set the priority class to use. Ref: https://kubernetes.io/docs/concepts/scheduling-eviction/pod-priority-preemption/#priorityclass |
8686
| controller.resources | object | `{}` | Set container resource requests and limits for Kubernetes Pod scheduling. Ref: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/#resource-requests-and-limits-of-pod-and-container |
8787
| controller.service | object | `{}` | The controller service configuration. Ref: https://kubernetes.io/docs/concepts/services-networking/service/ |
@@ -129,7 +129,7 @@ Helm Chart for Slurm HPC Workload Manager
129129
| mariadb.primary.persistence.labels | object | `{}` | |
130130
| mariadb.primary.persistence.selector | object | `{}` | |
131131
| mariadb.primary.persistence.size | string | `"8Gi"` | |
132-
| mariadb.primary.persistence.storageClass | string | `"standard"` | |
132+
| mariadb.primary.persistence.storageClass | string | `nil` | |
133133
| mariadb.primary.priorityClassName | string | `""` | |
134134
| mariadb.primary.tolerations | list | `[]` | |
135135
| mariadb.resources | object | `{}` | |

helm/slurm/values.yaml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -284,7 +284,7 @@ controller:
284284
#
285285
# -- (string)
286286
# Create a `PersistentVolumeClaim` with this storage class.
287-
storageClass: standard
287+
storageClass:
288288
#
289289
# -- (list)
290290
# Create a `PersistentVolumeClaim` with these access modes.
@@ -608,7 +608,7 @@ compute:
608608
# name: scratch
609609
# spec:
610610
# mountPath: /mnt/scratch
611-
# storageClassName: standard
611+
# storageClassName:
612612
# accessModes:
613613
# - ReadWriteOnce
614614
# resources:
@@ -849,7 +849,7 @@ mariadb:
849849
persistence:
850850
enabled: true
851851
existingClaim: ""
852-
storageClass: standard
852+
storageClass:
853853
labels: {}
854854
annotations: {}
855855
accessModes:

0 commit comments

Comments
 (0)