-
Notifications
You must be signed in to change notification settings - Fork 0
Added AIO tests + PyLint on PR #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 4 commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
b6c0cab
Added AIO tests on PR
wtripp180901 e7af581
now uses tests on branch
wtripp180901 20144bc
Added pylint
wtripp180901 32e1809
linter now outputs warning but doesn't fail
wtripp180901 04d4a48
now builds SKC image for testing
wtripp180901 5c8094a
fixed branch and variable names
wtripp180901 5a011f4
fixed wrong repos getting checked out
wtripp180901 d41d179
Merge branch 'main' into pr_tests
wtripp180901 46d93b2
rename
wtripp180901 6d3ff7b
removed image build and set skc version to main
wtripp180901 941501c
updated with new skc params
wtripp180901 d37e3a1
testing with old branch
wtripp180901 b94fa93
set to main branch
wtripp180901 291c859
updated with new SKC ref vars
wtripp180901 70d5306
overriding skc runs on
wtripp180901 27fd898
revert
wtripp180901 7629583
using new runner variable
wtripp180901 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,48 @@ | ||
name: Pull request | ||
on: | ||
pull_request: | ||
jobs: | ||
rocky9-ovs-aio-test: | ||
name: aio (Rocky 9 OVS) | ||
uses: stackhpc/stackhpc-kayobe-config/.github/workflows/stackhpc-all-in-one.yml@parameterise-aio-tests # todo: change after merge | ||
with: | ||
kayobe_image: ghcr.io/stackhpc/stackhpc-kayobe-config:stackhpc-2024.1 | ||
os_distribution: rocky | ||
os_release: "9" | ||
ssh_username: cloud-user | ||
neutron_plugin: ovs | ||
OS_CLOUD: openstack | ||
openstack_tests_version: ${{ github.ref }} | ||
secrets: inherit | ||
|
||
ubuntu-jammy-ovn-aio-test: | ||
name: aio (Ubuntu Jammy OVN) | ||
uses: stackhpc/stackhpc-kayobe-config/.github/workflows/stackhpc-all-in-one.yml@parameterise-aio-tests # todo: change after merge | ||
with: | ||
kayobe_image: ghcr.io/stackhpc/stackhpc-kayobe-config:stackhpc-2024.1 | ||
os_distribution: ubuntu | ||
os_release: jammy | ||
ssh_username: ubuntu | ||
neutron_plugin: ovn | ||
OS_CLOUD: openstack | ||
openstack_tests_version: ${{ github.ref }} | ||
secrets: inherit | ||
|
||
lint: | ||
runs-on: ubuntu-22.04 | ||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: Install pip dependencies | ||
run: pip install -r requirements.txt | ||
|
||
- name: Run pylint | ||
run: | | ||
set +e # disabling exit on non-zero error code so can output warnings without failing | ||
pylint stackhpc_openstack_tests/*.py | ||
EXIT_CODE=$? | ||
set -e | ||
if [[ $(($EXIT_CODE & 3)) > 0 ]] #bitwise check for pylint exit codes which indicate errors (01 and 10) https://pylint.readthedocs.io/en/latest/user_guide/usage/run.html#exit-codes | ||
then | ||
exit 1 | ||
fi |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,4 @@ | ||
opensearch-py==2.5.* | ||
prometheus-api-client==0.5.* | ||
pytest-testinfra==10.1.* | ||
pylint==3.3.* |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.