Skip to content

Conversation

Alex-Welsh
Copy link
Member

No description provided.

@Alex-Welsh Alex-Welsh requested a review from a team as a code owner September 11, 2024 13:37
@markgoddard
Copy link
Contributor

Quite a lot going on here

@Alex-Welsh
Copy link
Member Author

Quite a lot going on here

The only "real" changes are the 4 latest commits.

I based my changes on your branch, but also synced the latest stackhpc/2024.1 in.

# DIB_DISTRIBUTION_MIRROR: "{{ stackhpc_repo_ubuntu_focal_url if os_distribution == 'ubuntu' else '' }}"
DIB_DRACUT_ENABLED_MODULES_DEFAULT_CONFIG: "{{ stackhpc_overcloud_dib_dracut_enabled_modules_default_config }}"
# NOTE: DIB_ETC_HOSTS_EXTRA must be defined and cannot be an empty string
DIB_ETC_HOSTS_EXTRA: "#"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Better to remove L28?

@Alex-Welsh Alex-Welsh changed the base branch from caracal-selinux-permissive to stackhpc/2024.1 September 11, 2024 14:25
@Alex-Welsh Alex-Welsh marked this pull request as draft September 11, 2024 14:25
@Alex-Welsh Alex-Welsh force-pushed the caracal-image-build-alex branch from 47ab31e to bdb3f66 Compare September 11, 2024 14:39
@Alex-Welsh Alex-Welsh force-pushed the caracal-image-build-alex branch from bdb3f66 to a34d7a3 Compare September 11, 2024 14:42
@Alex-Welsh
Copy link
Member Author

This branch has become a mess. I'll close this PR and cherry-pick out the good bits.

@Alex-Welsh Alex-Welsh closed this Sep 13, 2024
@Alex-Welsh Alex-Welsh deleted the caracal-image-build-alex branch November 22, 2024 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants