Skip to content

CIS: Stop recursively setting permissions on logs files #1366

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Nov 7, 2024
Merged

CIS: Stop recursively setting permissions on logs files #1366

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f0e1cf5
CIS: Stop recursively setting permissions on logs files
jovial Nov 6, 2024
bc050c1
Merge branch 'stackhpc/2023.1' into bugfix/cis-log-perms
Alex-Welsh Nov 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions etc/kayobe/inventory/group_vars/cis-hardening/cis
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,9 @@ rhel9cis_rule_6_1_15: false
# filesystem. We do not want to change /var/lib/docker permissions.
rhel9cis_no_world_write_adjust: false

# Prevent hardening from recursivley changing permissions on log files
rhel9cis_rule_4_2_3: false

# Configure log rotation to prevent audit logs from filling the disk
rhel9cis_auditd:
space_left_action: syslog
Expand Down Expand Up @@ -153,6 +156,9 @@ ubtu22cis_no_owner_adjust: false
ubtu22cis_no_world_write_adjust: false
ubtu22cis_suid_adjust: false

# Prevent hardening from recursivley changing permissions on log files
ubtu22cis_rule_4_2_3: false

# Configure log rotation to prevent audit logs from filling the disk
ubtu22cis_auditd:
action_mail_acct: root
Expand Down
8 changes: 8 additions & 0 deletions releasenotes/notes/cis-hardening-no-longer-sets-permissions-on-logs-81a48ab8ed2d6b5f.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,8 @@
---
fixes:
- |
The CIS hardening scripts no longer change permissions of log files by
default. It is preferred to configure these permissions at source i.e on
whatever is creating the files. It also suffered from a time-of-check to
time-of-use race condition. If you want the old behaviour you can change
``rhel9cis_rule_4_2_3`` and/or ``ubtu22cis_rule_4_2_3`` to ``true``.
Loading