Skip to content

Generalise host image playbooks #1390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Dec 4, 2024
Merged

Generalise host image playbooks #1390

merged 10 commits into from
Dec 4, 2024

Conversation

assumptionsandg
Copy link
Contributor

Generalise image upload playbook so it can be used with Octavia and IPA image uploads.

@assumptionsandg assumptionsandg requested a review from a team as a code owner November 29, 2024 13:11
@assumptionsandg assumptionsandg added the Caracal Targets the Caracal OpenStack release label Nov 29, 2024
Alex-Welsh
Alex-Welsh reviewed Nov 29, 2024
View reviewed changes
Alex-Welsh
Alex-Welsh requested changes Dec 2, 2024
View reviewed changes
Alex-Welsh
Alex-Welsh reviewed Dec 3, 2024
View reviewed changes
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could we actually generalise this further? I think it would be quite easy to remove references to "image" and make the playbook usable for all file/artifact/object uploads

Alex-Welsh
Alex-Welsh requested changes Dec 3, 2024
View reviewed changes
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Once you've made these changes, could you give it a test? I think we can them merge

@assumptionsandg assumptionsandg changed the title Generalise image upload playbook Generalise host image playbooks Dec 4, 2024
@assumptionsandg
Copy link
Contributor Author

Tested:

Alex-Welsh
Alex-Welsh approved these changes Dec 4, 2024
View reviewed changes
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @assumptionsandg

@assumptionsandg assumptionsandg merged commit 56a7e85 into stackhpc/2024.1 Dec 4, 2024
12 checks passed
@assumptionsandg assumptionsandg deleted the upload-playbook branch December 4, 2024 17:38
assumptionsandg added a commit that referenced this pull request Dec 17, 2024
@assumptionsandg
Generalise host image playbooks (#1390)
1479d90 
* Generalise image upload playbook

* Replace occurences to host-image

* Variable for file extension

* Revert changes to overcloud image build

* Update file extension variable

* Use image name

* s/image/artifact/g

* Remove image_repository creds

* Fix artifact references in host-image-build

* Generalise promotion workflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alex-Welsh Alex-Welsh Alex-Welsh approved these changes

Assignees
No one assigned
Labels
Caracal Targets the Caracal OpenStack release size: m
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@assumptionsandg @Alex-Welsh