-
Notifications
You must be signed in to change notification settings - Fork 23
INFRA-839 Add playbooks, config & docs for enabling Pulp tls with vault #1427
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: stackhpc/2024.1
Are you sure you want to change the base?
Conversation
0281769
to
b69f2bd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Don't we also need to add the cert to the docker config directory? /etc/docker/certs/ I think.
If we can restart docker, this is not needed though.
Yeah, so I think docker will use the system CA trust but you might be right about needing to restart docker for that. Also if we did need to add the CA cert to docker I realised @seunghun1ee that we have a variable in kayobe for that
|
@technowhizz what is the expiry on the certs? Do we need a note on cert rotation in the docs? |
Add playbooks, config & docs for enabling pulp tls with vault
Dont start bifrost playbooks when deploying pulp tls Co-authored-by: Matt Crees <[email protected]>
751d275
to
e71ab9b
Compare
e71ab9b
to
11a9680
Compare
@Alex-Welsh once checks pass this should be good to go too. Unless also you want this in 2025.1 re cert rotation and length - its 1 year I believe like all the other certs. Nothing out of the ordinary, hence nothing worth mentioning. As far as rotation is concerned I think we need a note for all types not just pulp. Perhaps can be done as a follow up to this |
This has recently changed actually, https://github.com/stackhpc/stackhpc-kayobe-config/pull/1775/files
Yeah, if you could just rebase & change the target to 2025.1 that'd be great. |
No description provided.