Skip to content

feat: disable TMOUT for development environments #1464

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Feb 18, 2025
Merged

feat: disable TMOUT for development environments #1464

merged 2 commits into from
Feb 18, 2025
+38 −0

Conversation

jackhodgkiss
Copy link
Contributor

To avoid disruption to development work, disable the shell timeout for inactivity in the CIS hardening configuration for the ci-aio and ci-multinode environments.

@jackhodgkiss
feat: disable TMOUT for development environments
7ac7099 
To avoid disruption to development work, disable the shell timeout for
inactivity in the CIS hardening configuration for the `ci-aio` and
`ci-multinode` environments.
@jackhodgkiss jackhodgkiss added the enhancement New feature or request label Jan 16, 2025
@jackhodgkiss jackhodgkiss self-assigned this Jan 16, 2025
@jackhodgkiss jackhodgkiss requested a review from a team as a code owner January 16, 2025 11:08
@Alex-Welsh
Copy link
Member

Seems okay to me but since it's changing a security feature I'd like to get input from others. @priteau or @mnasiadka ?

@jackhodgkiss
Copy link
Contributor Author

Seems okay to me but since it's changing a security feature I'd like to get input from others. @priteau or @mnasiadka ?

Changing security only in specific environments for development.

@Alex-Welsh
Copy link
Member

Seems okay to me but since it's changing a security feature I'd like to get input from others. @priteau or @mnasiadka ?

Changing security only in specific environments for development.

They're also the only environments that we regularly test, so any difference to production is a risk

technowhizz
technowhizz approved these changes Jan 21, 2025
View reviewed changes
Copy link
Contributor

@technowhizz technowhizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and makes sense as being logged out is quite disruptive. Perhaps if others aren't fond of this we can bump the timeout value

@Alex-Welsh Alex-Welsh requested a review from priteau February 14, 2025 10:48
priteau
priteau approved these changes Feb 18, 2025
View reviewed changes
Copy link
Member

@priteau priteau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's merge this for now, but it would be nice to find a solution that fixes the issue for interactive environments while still applying the rule in unattended CI jobs (and potentially checking that it works as expected too).

@jackhodgkiss jackhodgkiss merged commit c42a7fc into stackhpc/2024.1 Feb 18, 2025
14 checks passed
@jackhodgkiss jackhodgkiss deleted the remove-tmout-for-dev-env branch February 18, 2025 11:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@priteau priteau priteau approved these changes

@technowhizz technowhizz technowhizz approved these changes

Assignees

@jackhodgkiss jackhodgkiss

Labels
enhancement New feature or request size: s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jackhodgkiss @Alex-Welsh @priteau @technowhizz