Skip to content

Conversation

technowhizz
Copy link
Contributor

No description provided.

@technowhizz technowhizz self-assigned this Feb 14, 2025
@technowhizz technowhizz requested a review from a team as a code owner February 14, 2025 23:36
@product-auto-label product-auto-label bot added size: s documentation Improvements or additions to documentation labels Feb 14, 2025
@technowhizz technowhizz force-pushed the upgrading-docs-blackbox branch 3 times, most recently from 76a896f to 800dfe6 Compare February 14, 2025 23:40
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change is coming in Epoxy, not Caracal, and I don't think we need the warning anyway. prometheus_blackbox_exporter_endpoints has been removed from the master branch already, so when we merge stackhpc/2025.1 to do the upgrades, it'll get removed automatically

@jackhodgkiss
Copy link
Contributor

This change is coming in Epoxy, not Caracal, and I don't think we need the warning anyway. prometheus_blackbox_exporter_endpoints has been removed from the master branch already, so when we merge stackhpc/2025.1 to do the upgrades, it'll get removed automatically

Though it won't be removed from a kolla/globals.yml inside an environment.

@Alex-Welsh
Copy link
Member

@technowhizz can you update this to target stackhpc/master and mention kolla/globals.yml inside an environment specifically?

@technowhizz technowhizz force-pushed the upgrading-docs-blackbox branch from 800dfe6 to 5a3e0b5 Compare March 27, 2025 09:47
@technowhizz technowhizz changed the base branch from stackhpc/2024.1 to stackhpc/master March 27, 2025 09:47
@technowhizz technowhizz requested a review from Alex-Welsh March 27, 2025 09:48
@Alex-Welsh
Copy link
Member

Alex-Welsh commented May 9, 2025

@technowhizz I'd like to get this wrapped up soon since the epoxy release isn't far away. Can you respond to the comments & resolve the merge conflict?

@technowhizz technowhizz force-pushed the upgrading-docs-blackbox branch from 5a3e0b5 to 0e12723 Compare May 13, 2025 15:32
@technowhizz technowhizz changed the base branch from stackhpc/master to stackhpc/2024.1 May 13, 2025 15:32
@technowhizz technowhizz changed the base branch from stackhpc/2024.1 to stackhpc/master May 13, 2025 15:33
@technowhizz technowhizz force-pushed the upgrading-docs-blackbox branch from 0e12723 to 791410e Compare May 13, 2025 15:35
@Alex-Welsh
Copy link
Member

@technowhizz I've added a suggestion, could you review please?

@Alex-Welsh Alex-Welsh requested a review from MoteHue June 12, 2025 12:54
MoteHue
MoteHue previously approved these changes Jun 12, 2025
Copy link
Contributor

@MoteHue MoteHue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Alex-Welsh Alex-Welsh merged commit 983971d into stackhpc/master Jun 12, 2025
20 checks passed
@Alex-Welsh Alex-Welsh deleted the upgrading-docs-blackbox branch June 12, 2025 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation size: s
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants