Fix playbook failure due to invalid escaped character #1609
+4
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…art command The playbook was failing when attempting to restart OpenStack services because of an invalid escaped character in the command that lists and restarts services. The original implementation used a shorthand systemctl flag (-a) along with a regular expression for egrep, which led to improper parsing and execution issues during the playbook run. This commit replaces the shorthand with a more explicit invocation that is confirmed to run without error: - Uses "systemctl list-units --type=service --all --no-legend --plain" to reliably list service units. - Adds the "-r" flag to xargs to avoid running systemctl restart without input, ensuring more predictable behavior. Note: This bug may be specific to hosts running Ubuntu Jammy
Alex-Welsh
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The playbook was failing when attempting to restart OpenStack services because of an invalid escaped character in the command that lists and restarts services. The original implementation used a shorthand systemctl flag (-a) along with a regular expression for egrep, which led to improper parsing and execution issues during the playbook run.
This PR replaces the shorthand with a more explicit invocation that is confirmed to run without error:
Note: This bug may be specific to hosts running Ubuntu Jammy