Fix RADOS gateway usage exporter deployment #1610
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
credential_check.stdout is a string representation of a list, and as such will never return true when compared to an empty Python list. Passing credential_check.stdout through the from_json filter casts the string to a list, and the equality can be properly evaluated.
m-bull
changed the title
|
Needs a reno, otherwise looks good |
By default Python requests uses its own CA bundle rather than the system trust store. As we optionally update the system trust store with our own CA, force Python requests to use the system trust store as its CA bundle.
m-bull
force-pushed
the
fix/rgw-usage-exporter-creds-check
branch
from
f751774 to
9dfc157
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
credential_check.stdout is a string representation of a list, and as such will never return true when compared to an empty Python list.
Passing credential_check.stdout through the from_json filter casts the string to a list, and the equality can be properly evaluated.