Skip to content

Conversation

priteau
Copy link
Member

@priteau priteau commented Jun 3, 2025

We tried adding upstream-sync using stackhpc-release-train [1], but the workflow addition is skipped because our default branch is a StackHPC release branch [2].

Add workflow manually to synchronise releases that still exist upstream.

[1] stackhpc/stackhpc-release-train#410
[2] stackhpc/stackhpc-release-train@49c06d1

@priteau priteau requested a review from Alex-Welsh June 3, 2025 10:07
@priteau priteau self-assigned this Jun 3, 2025
@priteau priteau requested a review from a team as a code owner June 3, 2025 10:07
@product-auto-label product-auto-label bot added size: s workflows Workflow files have been modified labels Jun 3, 2025
Copy link
Member

@Alex-Welsh Alex-Welsh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is on a "production" branch, could we add a check so it doesn't run on customer systems?

We tried adding upstream-sync using stackhpc-release-train [1], but the
workflow addition is skipped because our default branch is a StackHPC
release branch [2].

Add workflow manually to synchronise releases that still exist upstream.

[1] stackhpc/stackhpc-release-train#410
[2] stackhpc/stackhpc-release-train@49c06d1
@priteau priteau force-pushed the skc-upstream-sync branch from 46c7737 to bb093ca Compare June 3, 2025 10:17
@priteau
Copy link
Member Author

priteau commented Jun 3, 2025

Since this is on a "production" branch, could we add a check so it doesn't run on customer systems?

Good catch. I updated the workflow, hopefully with the right syntax?

@Alex-Welsh Alex-Welsh merged commit c2620d6 into stackhpc/2024.1 Jun 3, 2025
22 checks passed
@Alex-Welsh Alex-Welsh deleted the skc-upstream-sync branch June 3, 2025 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: s workflows Workflow files have been modified
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants